SLVS-1434 Extend JsonFileHandler #5661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aps the model from the logic model to the json model and vice-versa
terraform-techuser
changed the title
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource
approved these changes
Sep 2, 2024
| bool TryWriteToFile<T>(string filePath, T model) where T : class; | ||
| } | ||
|
|
||
| [Export(typeof(IJsonFileHandler))] | ||
| [PartCreationPolicy(CreationPolicy.Shared)] | ||
| [PartCreationPolicy(CreationPolicy.NonShared)] |
There was a problem hiding this comment.
Now that you removed the lock it doesn't actually matter if it's shared or not 😆
There was a problem hiding this comment.
Yes, but I don't think there is a good reason for it to be a singleton. In fact, it might be dangerous if in some point any state is being added to the class.
| /// <typeparam name="T">The type of the model that will be serialized</typeparam> | ||
| /// <param name="filePath">The path to the file</param> | ||
| /// <param name="content">The content of the file deserialized to the provided type</param> | ||
| /// <returns>True if the file could be read and the model could be serialized successfully. False otherwise</returns> | ||
| bool TryReadFile<T>(string filePath, out T content) where T : class; |
There was a problem hiding this comment.
Is this method going to be used anywhere?
There was a problem hiding this comment.
For now, I think not. I could remove it.
Base automatically changed from
gt/add-credentials-uri
to
feature/new-connected-mode
September 3, 2024 09:08
|
gabriela-trutan-sonarsource
merged commit 6dc2527
into
feature/new-connected-mode
1 of 2 checks passed
gabriela-trutan-sonarsource
added a commit
that referenced
this pull request
Sep 3, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Sep 12, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Sep 19, 2024
gabriela-trutan-sonarsource
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1434
This PR targets this PR as both are preparation for the server connection repository