Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVS-1613 Add conversion from TaintVulnerabilityDto to IAnalysisIssue #5818

Merged
merged 7 commits into from
Nov 12, 2024
Merged

SLVS-1613 Add conversion from TaintVulnerabilityDto to IAnalysisIssue #5818

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b36f014
SLVS-1613 Add conversion from TaintVulnerabilityDto to IAnalysisIssue
georgii-borovinskikh-sonarsource Nov 7, 2024
3726d6c
fix test
georgii-borovinskikh-sonarsource Nov 8, 2024
1e3a299
Fix tests
georgii-borovinskikh-sonarsource Nov 11, 2024
3c9a2fe
Throw when none of the severities are set for TaintIssue
georgii-borovinskikh-sonarsource Nov 11, 2024
74985ff
add todos for commented out tests
georgii-borovinskikh-sonarsource Nov 11, 2024
da62935
converter tests
georgii-borovinskikh-sonarsource Nov 11, 2024
a27bbb8
Small test cleanup, renamed TaintFlowLocationDto class
georgii-borovinskikh-sonarsource Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 66 additions & 56 deletions src/IssueViz.Security.UnitTests/Taint/Models/TaintIssueTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,74 +18,84 @@
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

using System;
using System.Collections.Generic;
using FluentAssertions;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Moq;
using SonarLint.VisualStudio.Core.Analysis;
using SonarLint.VisualStudio.IssueVisualization.Security.Taint;
using SonarLint.VisualStudio.IssueVisualization.Security.Taint.Models;

namespace SonarLint.VisualStudio.IssueVisualization.Security.UnitTests.Taint.Models
namespace SonarLint.VisualStudio.IssueVisualization.Security.UnitTests.Taint.Models;

[TestClass]
public class TaintIssueTests
{
[TestClass]
public class TaintIssueTests
[TestMethod]
public void Ctor_NullLocation_ArgumentNullException()
{
[TestMethod]
public void Ctor_NullLocation_ArgumentNullException()
{
Action act = () => new TaintIssue("issue key", "rule key",
null,
AnalysisIssueSeverity.Major, SoftwareQualitySeverity.High, DateTimeOffset.MinValue, DateTimeOffset.MinValue, null, null);
Action act = () => new TaintIssue("issue key", "rule key",
null,
AnalysisIssueSeverity.Major, SoftwareQualitySeverity.High, DateTimeOffset.MinValue, null, null);

act.Should().Throw<ArgumentNullException>().And.ParamName.Should().Be("primaryLocation");
}
act.Should().Throw<ArgumentNullException>().And.ParamName.Should().Be("primaryLocation");
}

[TestMethod]
public void Ctor_PropertiesSet()
{
var created = DateTimeOffset.Parse("2001-01-31T01:02:03+0200");
var lastUpdated = DateTimeOffset.UtcNow;
var issue = new TaintIssue("issue key", "rule key",
new AnalysisIssueLocation("message", "local-path.cpp", new TextRange(1, 2, 3, 4, "hash")),
AnalysisIssueSeverity.Major, SoftwareQualitySeverity.High, created, lastUpdated, null, "contextKey");
[TestMethod]
public void Ctor_PropertiesSet()
{
var created = DateTimeOffset.Parse("2001-01-31T01:02:03+0200");
var issue = new TaintIssue("issue key", "rule key",
new AnalysisIssueLocation("message", "local-path.cpp", new TextRange(1, 2, 3, 4, "hash")),
AnalysisIssueSeverity.Major, SoftwareQualitySeverity.High, created, null, "contextKey");

issue.IssueKey.Should().Be("issue key");
issue.RuleKey.Should().Be("rule key");
issue.Severity.Should().Be(AnalysisIssueSeverity.Major);
issue.CreationTimestamp.Should().Be(created);
issue.LastUpdateTimestamp.Should().Be(lastUpdated);
issue.RuleDescriptionContextKey.Should().Be("contextKey");
issue.IssueKey.Should().Be("issue key");
issue.RuleKey.Should().Be("rule key");
issue.Severity.Should().Be(AnalysisIssueSeverity.Major);
issue.CreationTimestamp.Should().Be(created);
issue.RuleDescriptionContextKey.Should().Be("contextKey");

issue.PrimaryLocation.FilePath.Should().Be("local-path.cpp");
issue.PrimaryLocation.Message.Should().Be("message");
issue.PrimaryLocation.TextRange.StartLine.Should().Be(1);
issue.PrimaryLocation.TextRange.EndLine.Should().Be(2);
issue.PrimaryLocation.TextRange.StartLineOffset.Should().Be(3);
issue.PrimaryLocation.TextRange.EndLineOffset.Should().Be(4);
issue.PrimaryLocation.TextRange.LineHash.Should().Be("hash");
}
issue.PrimaryLocation.FilePath.Should().Be("local-path.cpp");
issue.PrimaryLocation.Message.Should().Be("message");
issue.PrimaryLocation.TextRange.StartLine.Should().Be(1);
issue.PrimaryLocation.TextRange.EndLine.Should().Be(2);
issue.PrimaryLocation.TextRange.StartLineOffset.Should().Be(3);
issue.PrimaryLocation.TextRange.EndLineOffset.Should().Be(4);
issue.PrimaryLocation.TextRange.LineHash.Should().Be("hash");
}

[TestMethod]
public void Ctor_NoFlows_EmptyFlows()
{
IReadOnlyList<IAnalysisIssueFlow> flows = null;
var issue = new TaintIssue("issue key", "rule key",
new AnalysisIssueLocation("message", "local-path.cpp", new TextRange(1, 2, 3, 4, "hash")),
AnalysisIssueSeverity.Major, SoftwareQualitySeverity.High, DateTimeOffset.MinValue, DateTimeOffset.MaxValue, flows, null);
[TestMethod]
public void Ctor_NoFlows_EmptyFlows()
{
IReadOnlyList<IAnalysisIssueFlow> flows = null;
var issue = new TaintIssue("issue key", "rule key",
new AnalysisIssueLocation("message", "local-path.cpp", new TextRange(1, 2, 3, 4, "hash")),
AnalysisIssueSeverity.Major, SoftwareQualitySeverity.High, DateTimeOffset.MinValue, flows, null);

issue.Flows.Should().BeEmpty();
}
issue.Flows.Should().BeEmpty();
}

[TestMethod]
public void Ctor_HasFlows_CorrectFlows()
{
var flows = new[] { Mock.Of<IAnalysisIssueFlow>(), Mock.Of<IAnalysisIssueFlow>() };
var issue = new TaintIssue("issue key", "rule key",
new AnalysisIssueLocation("message", "local-path.cpp", new TextRange(1, 2, 3, 4, "hash")),
AnalysisIssueSeverity.Major, SoftwareQualitySeverity.High, DateTimeOffset.MinValue, DateTimeOffset.MaxValue, flows, null);
[TestMethod]
public void Ctor_HasFlows_CorrectFlows()
{
var flows = new[] { Substitute.For<IAnalysisIssueFlow>(), Substitute.For<IAnalysisIssueFlow>() };
var issue = new TaintIssue("issue key", "rule key",
new AnalysisIssueLocation("message", "local-path.cpp", new TextRange(1, 2, 3, 4, "hash")),
AnalysisIssueSeverity.Major, SoftwareQualitySeverity.High, DateTimeOffset.MinValue, flows, null);

issue.Flows.Should().BeEquivalentTo(flows);
}

[TestMethod]
public void Ctor_HasNoStandardAndNoCCTSeverity_Throws()
{
AnalysisIssueSeverity? analysisIssueSeverity = null;
SoftwareQualitySeverity? highestSoftwareQualitySeverity = null;
var act = () => new TaintIssue("issue key",
"rule key",
new AnalysisIssueLocation("msg", "local-path.cpp", new TextRange(1, 2, 3, 4, "hash")),
analysisIssueSeverity,
highestSoftwareQualitySeverity,
DateTimeOffset.Now,
[],
null);

issue.Flows.Should().BeEquivalentTo(flows);
}
act.Should().Throw<ArgumentException>().WithMessage(string.Format(TaintResources.TaintIssue_SeverityUndefined, "issue key"));
}
}
Loading