Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1613 Add conversion from TaintVulnerabilityDto to IAnalysisIssue #5818

Merged
merged 7 commits into from
Nov 12, 2024
Merged

SLVS-1613 Add conversion from TaintVulnerabilityDto to IAnalysisIssue #5818

merged 7 commits into from
Nov 12, 2024

Conversation

georgii-borovinskikh-sonarsource
Copy link
Contributor

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource commented Nov 8, 2024 •
edited by jira bot
Loading

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource marked this pull request as ready for review November 11, 2024 11:46
gabriela-trutan-sonarsource
gabriela-trutan-sonarsource approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some feedback regarding the tests: some test names are wrong/confusing and some code could be extracted to look a little bit cleaner

src/IssueViz.Security.UnitTests/Taint/TaintIssueToIssueVisualizationConverterTests.cs Outdated Show resolved Hide resolved
src/IssueViz.Security.UnitTests/Taint/TaintIssueToIssueVisualizationConverterTests.cs Outdated Show resolved Hide resolved
src/IssueViz.Security.UnitTests/Taint/TaintIssueToIssueVisualizationConverterTests.cs Show resolved Hide resolved
src/IssueViz.Security.UnitTests/Taint/TaintIssueToIssueVisualizationConverterTests.cs Show resolved Hide resolved
src/IssueViz.Security.UnitTests/Taint/TaintIssueToIssueVisualizationConverterTests.cs Show resolved Hide resolved
src/IssueViz.Security.UnitTests/Taint/TaintIssueToIssueVisualizationConverterTests.cs Show resolved Hide resolved
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource mentioned this pull request Nov 11, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
5 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource merged commit e8d8254 into feature/severity-modes Nov 12, 2024
2 checks passed
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource deleted the gb/taint-dto-conversion branch November 12, 2024 09:00
vnaskos-sonar pushed a commit that referenced this pull request Nov 18, 2024
@georgii-borovinskikh-sonarsource @vnaskos-sonar
SLVS-1613 Add conversion from TaintVulnerabilityDto to IAnalysisIssue (…
515cc73 
…#5818)
georgii-borovinskikh-sonarsource added a commit that referenced this pull request Nov 20, 2024
@georgii-borovinskikh-sonarsource
SLVS-1613 Add conversion from TaintVulnerabilityDto to IAnalysisIssue (…
d4bb713 
…#5818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource gabriela-trutan-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgii-borovinskikh-sonarsource @gabriela-trutan-sonarsource