Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up units #109

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Clean up units #109

merged 3 commits into from
Apr 12, 2024

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Apr 11, 2024

  • Remove deprecated hPA unit from barometer sensor
  • Remove redundant mW unit from power_consumption sensor
  • Clean up nonsensical unit descriptions

There are other redundant units, for example temperature in kelvin or fahrenheit (and many others), or wind speed in m/s vs km/h. However, I decided not to touch those for now.

@dbrgn dbrgn added this to the API v15 milestone Apr 11, 2024
@dbrgn dbrgn requested a review from a team April 11, 2024 21:45
@dbrgn dbrgn self-assigned this Apr 11, 2024
@s3lph
Copy link
Contributor

s3lph commented Apr 12, 2024

I had a quick look through all the endpoints in the directory:

  • The mW unit isn't used anywhere.
  • The hPA unit is still used in 3 endpoints, but it's been deprecated long enough to warrant removal.

@dbrgn
Copy link
Contributor Author

dbrgn commented Apr 12, 2024

@s3lph great, thanks for the check!

@dbrgn dbrgn merged commit 3d88ec3 into master Apr 12, 2024
8 checks passed
@dbrgn dbrgn deleted the units-cleanup branch April 12, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants