Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up units #109

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Clean up units #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ddea98
Remove deprecated hPA unit from barometer sensor
dbrgn Apr 11, 2024
6347196
Remove redundant mW unit from power_consumption sensor
dbrgn Apr 11, 2024
53c1c1c
Clean up nonsensical unit descriptions
dbrgn Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions 15-draft.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,11 +414,10 @@
"type": "number"
},
"unit": {
"description": "The unit of pressure used by your sensor<br>Note: The <code>hPA</code> unit is deprecated and should not be used anymore. Use the correct <code>hPa</code> unit instead.",
"description": "The unit of pressure used by your sensor",
"type": "string",
"enum": [
"hPa",
"hPA"
"hPa"
]
},
"location": {
Expand Down Expand Up @@ -695,7 +694,7 @@
"type": "number"
},
"unit": {
"description": "The unit of the sensor value. You should always define the unit though if the sensor is a flag of a boolean type then you can of course omit it.",
"description": "The humidity unit",
"type": "string",
"enum": [
"%"
Expand Down Expand Up @@ -788,10 +787,9 @@
"type": "number"
},
"unit": {
"description": "The unit of the sensor value. You should always define the unit though if the sensor is a flag of a boolean type then you can of course omit it.",
"description": "The power unit",
"type": "string",
"enum": [
"mW",
"W",
"VA"
]
Expand Down Expand Up @@ -889,7 +887,7 @@
"type": "number"
},
"unit": {
"description": "The unit of the sensor value. You should always define the unit though if the sensor is a flag of a boolean type then you can of course omit it.",
"description": "The wind speed unit",
"type": "string",
"enum": [
"m/s",
Expand All @@ -912,7 +910,7 @@
"type": "number"
},
"unit": {
"description": "The unit of the sensor value. You should always define the unit though if the sensor is a flag of a boolean type then you can of course omit it.",
"description": "The gust speed unit",
"type": "string",
"enum": [
"m/s",
Expand All @@ -935,7 +933,7 @@
"type": "number"
},
"unit": {
"description": "The unit of the sensor value. You should always define the unit though if the sensor is a flag of a boolean type then you can of course omit it.",
"description": "The direction unit",
"type": "string",
"enum": [
"°"
Expand All @@ -956,7 +954,7 @@
"type": "number"
},
"unit": {
"description": "The unit of the sensor value. You should always define the unit though if the sensor is a flag of a boolean type then you can of course omit it.",
"description": "The elevation unit",
"type": "string",
"enum": [
"m"
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ Changes should start with one of the following tags:
- `[changed]` for changes to the existing API
- `[removed]` for keys that have been removed from the schema

## v15

`sensors`:

- [removed] The deprecated unit `hPA` in `barometer.unit` was removed, use `hPa` instead ([#109])
- [removed] The redundant unit `mW` in `power_consumption.unit` was removed, use `W` instead ([#109])

## v14

Root level:
Expand Down Expand Up @@ -73,3 +80,4 @@ Root level:
[#72]: https://github.com/SpaceApi/schema/pull/72
[#77]: https://github.com/SpaceApi/schema/pull/77
[#80]: https://github.com/SpaceApi/schema/pull/80
[#109]: https://github.com/SpaceApi/schema/pull/109
Loading