Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deck-roulette plugin with tag 1.1.6 #717

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Chrisae9
Copy link

@Chrisae9 Chrisae9 commented Nov 1, 2024

Deck Roulette

The Deck-Roulette plugin provides a roulette-style game selection experience for users, allowing them to randomly choose games from their library.

I have forked the original repository and made updates to restore the plugin's functionality. This PR aims to provide a working version back in the store for the community's continued use.

Reasons for Changing Ownership

The plugin was removed from the store due to the original developer's absence. I reached out in the DeckRoulette support thread in the main Discord but have not received a response. Despite this, I've noticed continued interest from users, as many have been installing the plugin from my fork via zip files.

Task Checklist

Developer

  • The original author or authorized maintainer of this plugin has either agreed to the transfer or has been unresponsive for an extended period as described above.
  • I am accept the responsibility of becoming the authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or provides more/alternative functionality to a plugin already on the store.

Backend

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Community

  • I have tested and left feedback on two other pull requests for new or updating plugins.
  • I have commented links to my testing report in this PR.

Testing

  • Tested on SteamOS Stable or Beta update channel.

@TrainDoctor
Copy link
Member

@Chrisae9 if you would like to continue this PR please bump the plugin version by a patch and then rebase onto latest main for the plugin repo.
I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request that a member of the SDH team tests your plugin update/submission according to the testing guidelines.

@Chrisae9 Chrisae9 changed the title Add deck-roulette plugin with tag 1.1.5 Add deck-roulette plugin with tag 1.1.6 Jan 19, 2025
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes, looks good for testing.

@TrainDoctor TrainDoctor requested review from a team January 19, 2025 20:01
@ohaiibuzzle ohaiibuzzle mentioned this pull request Jan 21, 2025
7 tasks
@justjoeyuk justjoeyuk mentioned this pull request Jan 24, 2025
8 tasks
@justjoeyuk
Copy link

justjoeyuk commented Jan 24, 2025

Plugin Testing Report

Installed Plugins

  • Audio Loader- 1.6.0
  • Deck Settings - 0.0.1
  • Game Theme Music - 1.7.0
  • DeckRoulette - 1.1.6
  • EmuDecky - 1.0.8
  • vibrantDeck - 2.0.1
  • SimpleTimer - 0.9.0
  • CSS Loader - 2.1.2
  • Junk-Store - 1.1.8
  • SteamGridDB - 1.5.1-loaderv2

Specifications

  • SteamOS 3.6.21 (Beta)
  • Steam 1737601106 (Beta)
  • Decky 3.1.2-pre1 (Pre-Release)

Issues

Has the following major blocking issue(s): None Identified
Has the following minor non-blocking issue(s): None Identified

Summary

I tested this plugin with a number of different collections, and with my wider game library. I tested on a collection with 3 games, and it eventually suggested all 3 games and after over a dozen attempts, maintained a random output. With my wider collection, it consistently returned random results several times. Testing indicates that it selects from random with every game in the list.

@xXJSONDeruloXx
Copy link
Contributor

xXJSONDeruloXx commented Jan 25, 2025

Plugin Testing Report

Installed Plugins

  • Pause Games - 1.0.0-b2be59f
  • PlayTime - 2.0.9-c9445a5
  • HLTB for Deck 2.04-7d39e65
  • DeckSettings - 0.0.0-9fc66b1
  • Audio Loader - 1.6.0
  • MagicPods 1.0.7
  • Decky Terminal - 0.4.1
  • SteamGridDB 1.5.1-loaderv2
  • ProtonDB Badges - 1.1.0
  • Junk-Store - 1.1.8
  • CSS Loader - 2.1.2
  • Crosshairs- 1.0.0
  • DeckRoulette - 1.1.6-d0eea04
  • Decky Framegen - 0.0.1

Specifications

  • SteamOS 3.6.20 (stable
  • Steam 1737514353 (stable)
  • Decky 3.0.5 (stable)

Issues

Has the following major blocking issue(s): NONE
Has the following minor non-blocking issue(s): NONE

Summary

No issues, tested on testing store build and all categories worked great, steam and non steam games alike!

@xXJSONDeruloXx xXJSONDeruloXx mentioned this pull request Jan 25, 2025
7 tasks
@EMERALD0874
Copy link
Member

@Chrisae9 Your PR has been updated to use the latest version of the PR template. Please see the Community section of the Task Checklist regarding testing two other PRs to get the quickest response from our team. There are additional comments in the Markdown when you edit the PR text which you may find helpful. Thanks!

@EMERALD0874
Copy link
Member

@Chrisae9 I'm happy to merge this if you don't mind adding yourself to the plugin.json as an author along with the original plugin author. My concern is people attempting to reach out to the previous maintainer for support when they don't appear to be available/interested.

@ohaiibuzzle
Copy link
Contributor

Plugin Testing Report

Installed Plugins

  • DeckRoulette - 1.1.6-b5e6ebb
  • Decky-SpoofDPI - 0.12.0-3
  • ProtonDB Badges - 1.1.0
  • CSS Loader - 2.1.2
  • Free Loader - 1.3.0
  • PowerTools - 2.0.3
  • Shotty - 0.1.0
  • Decky Terminal - 0.4.1
  • AutoFlatpaks - 1.6.7
  • DeckyFileServer - 0.3.0
  • Tailscale Control - 0.1.3
  • Animation Changer - 1.3.1
  • Battery Tracker - 0.2.0
  • SteamGridDB - 1.5.1-loaderv2
  • Decky DoT DNS - 0.0.3

Specifications

  • SteamOS 3.6.20 (Stable)
  • Steam 1738026274 (Stable)
  • Decky v3.0.5 (Stable)

Issues

Has the following major blocking issue(s): None
Has the following minor non-blocking issue(s): None

Summary

Plugin works as expected after ~10 cycles for each options, generating randomized items for categories provided by the plugin

Copy link
Member

@EMERALD0874 EMERALD0874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin.json only refers to original maintainer, not the new one. This could lead to issues with users trying to get support on the wrong fork. Please add your name before the original author's name (ex. Chrisae9, OriginalAuthorName)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

7 participants