-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deck-roulette plugin with tag 1.1.6 #717
base: main
Are you sure you want to change the base?
Conversation
@Chrisae9 if you would like to continue this PR please bump the plugin version by a patch and then rebase onto latest main for the plugin repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changes, looks good for testing.
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): None Identified SummaryI tested this plugin with a number of different collections, and with my wider game library. I tested on a collection with 3 games, and it eventually suggested all 3 games and after over a dozen attempts, maintained a random output. With my wider collection, it consistently returned random results several times. Testing indicates that it selects from random with every game in the list. |
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): NONE SummaryNo issues, tested on testing store build and all categories worked great, steam and non steam games alike! |
@Chrisae9 Your PR has been updated to use the latest version of the PR template. Please see the Community section of the Task Checklist regarding testing two other PRs to get the quickest response from our team. There are additional comments in the Markdown when you edit the PR text which you may find helpful. Thanks! |
@Chrisae9 I'm happy to merge this if you don't mind adding yourself to the plugin.json as an author along with the original plugin author. My concern is people attempting to reach out to the previous maintainer for support when they don't appear to be available/interested. |
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): None SummaryPlugin works as expected after ~10 cycles for each options, generating randomized items for categories provided by the plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin.json only refers to original maintainer, not the new one. This could lead to issues with users trying to get support on the wrong fork. Please add your name before the original author's name (ex. Chrisae9, OriginalAuthorName)
Deck Roulette
The Deck-Roulette plugin provides a roulette-style game selection experience for users, allowing them to randomly choose games from their library.
I have forked the original repository and made updates to restore the plugin's functionality. This PR aims to provide a working version back in the store for the community's continued use.
Reasons for Changing Ownership
The plugin was removed from the store due to the original developer's absence. I reached out in the DeckRoulette support thread in the main Discord but have not received a response. Despite this, I've noticed continued interest from users, as many have been installing the plugin from my fork via zip files.
Task Checklist
Developer
Plugin
Backend
Community
Testing