Download contributed build as tarball #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks nice and clean! The three new package dependencies (Downloads, Tar, CodecZlib) all seem pretty "Julia official". The PR currently extracts into Tar.extract(tar, joinpath(@__DIR__, "src", "examples", "contributed")Then we would no longer need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #203. The Sunny doc building process no longer attempts a sparse checkout of the SunnyContributed build folder. Instead, the make file on the SunnyContributed side now stores the results of its build in a tarball, and this tarball is downloaded directly during the Sunny.jl doc build without using git.
Associated changes to SunnyContributed were made in this commit (see changes to
make.jl).