Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWED-2379 migrate components snippets icons #933

Merged

Conversation

goldenraphti
Copy link
Collaborator

@goldenraphti goldenraphti commented Jan 15, 2024

Corresponds to Jira ticket SWED-2379

  • migrate all components instances of material-icons
    • some of them were exposed, via the HTML snippets that are supposed to be copied over
    • some were hidden behind the curtain by being set via CSS pseudo-elements

This PR is delicate, since it is touching the components. It can therefore introduce breaking changes - BUT IT SHOULD NOT- . The idea is that migration can be done at the pace of each project. So we modify the example, the code snippets, BUT the components should STILL support material-icons with NO MODIFICATION needed by the developers of the projects consuming the package.

IF some breaking change MUST be introduced, let's mark them very clearly to communicate around it very clearly.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (88d6320) 72.41% compared to head (67eec45) 72.39%.
Report is 15 commits behind head on develop.

❗ Current head 67eec45 differs from pull request most recent head 666adb8. Consider uploading reports for the commit 666adb8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #933      +/-   ##
===========================================
- Coverage    72.41%   72.39%   -0.02%     
===========================================
  Files          212      211       -1     
  Lines         4604     4605       +1     
  Branches      1309     1309              
===========================================
  Hits          3334     3334              
- Misses        1126     1127       +1     
  Partials       144      144              
Files Coverage Δ
src/App/AppHeader/index.js 57.14% <ø> (ø)
...onentsDocumentation/components/ActionList/index.js 90.90% <ø> (ø)
...onentsDocumentation/components/Alerts/constants.js 100.00% <ø> (ø)
...ComponentsDocumentation/components/Alerts/index.js 57.14% <ø> (ø)
...nentsDocumentation/components/Buttons/constants.js 100.00% <ø> (ø)
...mponentsDocumentation/components/Card/constants.js 100.00% <ø> (ø)
...ComponentsDocumentation/components/Charts/index.js 93.33% <ø> (ø)
...mponentsDocumentation/components/CodeTags/index.js 66.66% <ø> (ø)
...nentsDocumentation/components/Datepickers/index.js 83.33% <ø> (ø)
...ComponentsDocumentation/components/Dialog/index.js 60.00% <ø> (ø)
... and 73 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28aa610...666adb8. Read the comment docs.

Copy link

Size Change: +13.3 kB (+1%)

Total Size: 1.14 MB

Filename Size Change
dist/designguide/styles/payex.css 47.7 kB +3.33 kB (+8%) 🔍
dist/designguide/styles/swedbankpay.css 45.4 kB +3.14 kB (+7%) 🔍
dist/styles/payex.css 47.7 kB +3.33 kB (+8%) 🔍
dist/styles/swedbankpay.css 45.4 kB +3.14 kB (+7%) 🔍
ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.7 kB +20 B (0%)
dist/designguide/styles/documentation-payex.css 9.97 kB +77 B (+1%)
dist/designguide/styles/documentation-swedbankpay.css 9.07 kB +89 B (+1%)
dist/scripts/9438.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.7 kB +20 B (0%)
dist/scripts/payex.js 322 kB +2 B (0%)
dist/scripts/swedbankpay.js 322 kB +4 B (0%)
dist/styles/documentation-payex.css 9.97 kB +77 B (+1%)
dist/styles/documentation-swedbankpay.css 9.07 kB +89 B (+1%)

compressed-size-action

Copy link

github-actions bot commented Jan 22, 2024

Size Change: +2.62 kB (0%)

Total Size: 1.14 MB

Filename Size Change
dist/designguide/styles/payex.css 48 kB +661 B (+1%)
dist/designguide/styles/swedbankpay.css 45.5 kB +621 B (+1%)
dist/styles/payex.css 48 kB +661 B (+1%)
dist/styles/swedbankpay.css 45.5 kB +621 B (+1%)
ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.7 kB +4 B (0%)
dist/designguide/styles/documentation-payex.css 10 kB +37 B (0%)
dist/designguide/styles/documentation-swedbankpay.css 9.07 kB +48 B (+1%)
dist/scripts/712.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.7 kB +4 B (0%)
dist/scripts/payex.js 322 kB -62 B (0%)
dist/scripts/swedbankpay.js 323 kB -61 B (0%)
dist/styles/documentation-payex.css 10 kB +37 B (0%)
dist/styles/documentation-swedbankpay.css 9.07 kB +48 B (+1%)

compressed-size-action

@goldenraphti goldenraphti marked this pull request as ready for review February 8, 2024 12:16
@goldenraphti goldenraphti merged commit 9d2dfce into develop Feb 12, 2024
8 checks passed
@github-actions github-actions bot deleted the feature/SWED-2379-migrate_components_snippets_icons branch February 12, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant