-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWED-2379 migrate components snippets icons #933
SWED-2379 migrate components snippets icons #933
Conversation
…-2379-migrate_components_snippets_icons
…-2379-migrate_components_snippets_icons
…-2379-migrate_components_snippets_icons
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #933 +/- ##
===========================================
- Coverage 72.41% 72.39% -0.02%
===========================================
Files 212 211 -1
Lines 4604 4605 +1
Branches 1309 1309
===========================================
Hits 3334 3334
- Misses 1126 1127 +1
Partials 144 144
Continue to review full report in Codecov by Sentry.
|
Size Change: +13.3 kB (+1%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
Size Change: +2.62 kB (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
Corresponds to Jira ticket SWED-2379
This PR is delicate, since it is touching the components. It can therefore introduce breaking changes - BUT IT SHOULD NOT- . The idea is that migration can be done at the pace of each project. So we modify the example, the code snippets, BUT the components should STILL support material-icons with NO MODIFICATION needed by the developers of the projects consuming the package.
IF some breaking change MUST be introduced, let's mark them very clearly to communicate around it very clearly.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Review instructions
Review instructions