Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWED-2379 migrate components snippets icons #933

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
37ea45f
SWED-2379 migrate components snippets #1
goldenraphti Jan 15, 2024
be049bc
Merge branch 'feature/SWED-2276-icon_library_atlas' into feature/SWED…
goldenraphti Jan 15, 2024
a7c0b7f
SWED-2379 fix links icon migration & pure CSS
goldenraphti Jan 15, 2024
eee6430
Merge branch 'feature/SWED-2276-icon_library_atlas' into feature/SWED…
goldenraphti Jan 16, 2024
6fc92f1
SWED-2379 migrate icons components snippets #2
goldenraphti Jan 16, 2024
1786633
SWED-2379 migrate icons components snippets #3
goldenraphti Jan 17, 2024
31c2519
Merge branch 'feature/SWED-2276-icon_library_atlas' into feature/SWED…
goldenraphti Jan 17, 2024
a7a7e3d
SWED-2379 migrate icons components snippets #4
goldenraphti Jan 17, 2024
67eec45
SWED-2379 migrate icons components snippets & fix tests
goldenraphti Jan 22, 2024
247c860
SWED-2379 fix E2E tests icons migration
goldenraphti Jan 30, 2024
d8f0dd7
Merge branch 'develop' into feature/SWED-2379-migrate_components_snip…
goldenraphti Feb 8, 2024
9bd1fd8
SWED-2379 migrate material-icons OldCard
goldenraphti Feb 8, 2024
4381528
SWED-2379 fix datepicker icon
goldenraphti Feb 8, 2024
c36a385
SWED-2379 update dialog & tag close button
goldenraphti Feb 8, 2024
6df3ce1
SWED-2379 update icons action-list
goldenraphti Feb 8, 2024
eb84f23
SWED-2379 update toast
goldenraphti Feb 8, 2024
394b434
SWED-2379 update typography icon payex
goldenraphti Feb 9, 2024
225ba51
SWED-2379 update Jest tests
goldenraphti Feb 12, 2024
3cf8957
SWED-2379 update Jest tests
goldenraphti Feb 12, 2024
666adb8
SWED-2379 fix css media-object
goldenraphti Feb 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,25 @@
# Changelog

## \[10.10.1\] - 06.02.2024
## \[10.10.1\] - xx.02.2024

## Component changes

### Non breaking UI changes

- Icons migration step 2 (still non-breaking. But the migrations is decided and is happening, so move when you can. Silent support of Material-icons until next major version release).
- Toast icons are modified. Since Toast is created entirely via a script shipped in the package, nothing is requiring from devs consuming the package. But expect a change in the icon used by the Toast component.

### NON Breaking UI changes BUT CAN & SHOULD modify code when have time

- Tags
- the close icon is now a cross set via CSS only, no need to add an `<i>` element anymore
- Dialog
- the close icon is now a cross set via CSS only, no need to add an `<i>` element anymore

## Maintenance

- npm packages dependencies upgrades

## Design System website

- Migrated the icons used on the documentation website from Material-icons to a combination of Atlas and our own custom swepay-icons
- Migrate icons used on the DS documentation website from Material-icons to Atlas + Swepay-icon custom icons
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ exports[`Components: ActionList renders 1`] = `

<i
aria-hidden="true"
className="at-exclamation-triangle"
className="swepay-icon-error-triangle-filled"
/>
<p>
<b>
Expand Down Expand Up @@ -752,10 +752,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
bookmark
</i>
className="at-bookmark-star small"
/>
Add bookmark
</a>

Expand All @@ -766,10 +764,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
business_center
</i>
className="at-business-suitcase small"
/>
Add client
</a>

Expand All @@ -780,10 +776,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
add_circle
</i>
className="at-plus-circle small"
/>
Add document
</a>

Expand All @@ -794,10 +788,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
person_add
</i>
className="at-user-plus small"
/>
Add user
</a>

Expand Down Expand Up @@ -893,16 +885,16 @@ exports[`Components: ActionList renders 1`] = `
&lt;div class="action-menu" aria-labelledby="actionListToggle"&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;bookmark&lt;/i&gt;Add bookmark&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-bookmark-star small" aria-hidden="true"&gt;&lt;/i&gt;Add bookmark&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;business_center&lt;/i&gt;Add client&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-business-suitcase small" aria-hidden="true"&gt;&lt;/i&gt;Add client&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;add_circle&lt;/i&gt;Add document&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-plus-circle small" aria-hidden="true"&gt;&lt;/i&gt;Add document&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;person_add&lt;/i&gt;Add user&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-user-plus small" aria-hidden="true"&gt;&lt;/i&gt;Add user&lt;/a&gt;


&lt;/div&gt;
Expand Down Expand Up @@ -976,10 +968,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
bookmark
</i>
className="at-bookmark-star small"
/>
Add bookmark
</a>

Expand All @@ -990,10 +980,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
business_center
</i>
className="at-business-suitcase small"
/>
Add client
</a>

Expand All @@ -1004,10 +992,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
add_circle
</i>
className="at-plus-circle small"
/>
Add document
</a>

Expand All @@ -1018,10 +1004,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
person_add
</i>
className="at-user-plus small"
/>
Add user
</a>

Expand Down Expand Up @@ -1117,16 +1101,16 @@ exports[`Components: ActionList renders 1`] = `
&lt;div class="action-menu" aria-labelledby="actionListToggle"&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;bookmark&lt;/i&gt;Add bookmark&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-bookmark-star small" aria-hidden="true"&gt;&lt;/i&gt;Add bookmark&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;business_center&lt;/i&gt;Add client&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-business-suitcase small" aria-hidden="true"&gt;&lt;/i&gt;Add client&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;add_circle&lt;/i&gt;Add document&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-plus-circle small" aria-hidden="true"&gt;&lt;/i&gt;Add document&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;person_add&lt;/i&gt;Add user&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-user-plus small" aria-hidden="true"&gt;&lt;/i&gt;Add user&lt;/a&gt;


&lt;/div&gt;
Expand Down Expand Up @@ -1192,10 +1176,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
bookmark
</i>
className="at-bookmark-star small"
/>
Add bookmark
</a>

Expand All @@ -1206,10 +1188,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
business_center
</i>
className="at-business-suitcase small"
/>
Add client
</a>

Expand All @@ -1220,10 +1200,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
add_circle
</i>
className="at-plus-circle small"
/>
Add document
</a>

Expand All @@ -1234,10 +1212,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
person_add
</i>
className="at-user-plus small"
/>
Add user
</a>

Expand Down Expand Up @@ -1333,16 +1309,16 @@ exports[`Components: ActionList renders 1`] = `
&lt;div class="action-menu" aria-labelledby="actionListToggle"&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;bookmark&lt;/i&gt;Add bookmark&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-bookmark-star small" aria-hidden="true"&gt;&lt;/i&gt;Add bookmark&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;business_center&lt;/i&gt;Add client&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-business-suitcase small" aria-hidden="true"&gt;&lt;/i&gt;Add client&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;add_circle&lt;/i&gt;Add document&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-plus-circle small" aria-hidden="true"&gt;&lt;/i&gt;Add document&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;person_add&lt;/i&gt;Add user&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-user-plus small" aria-hidden="true"&gt;&lt;/i&gt;Add user&lt;/a&gt;


&lt;/div&gt;
Expand Down Expand Up @@ -1408,10 +1384,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
bookmark
</i>
className="at-bookmark-star small"
/>
Add bookmark
</a>

Expand All @@ -1422,10 +1396,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
business_center
</i>
className="at-business-suitcase small"
/>
Add client
</a>

Expand All @@ -1436,10 +1408,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
add_circle
</i>
className="at-plus-circle small"
/>
Add document
</a>

Expand All @@ -1450,10 +1420,8 @@ exports[`Components: ActionList renders 1`] = `
>
<i
aria-hidden="true"
className="material-icons"
>
person_add
</i>
className="at-user-plus small"
/>
Add user
</a>

Expand Down Expand Up @@ -1549,16 +1517,16 @@ exports[`Components: ActionList renders 1`] = `
&lt;div class="action-menu" aria-labelledby="actionListToggle"&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;bookmark&lt;/i&gt;Add bookmark&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-bookmark-star small" aria-hidden="true"&gt;&lt;/i&gt;Add bookmark&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;business_center&lt;/i&gt;Add client&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-business-suitcase small" aria-hidden="true"&gt;&lt;/i&gt;Add client&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;add_circle&lt;/i&gt;Add document&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-plus-circle small" aria-hidden="true"&gt;&lt;/i&gt;Add document&lt;/a&gt;


&lt;a href="#"&gt;&lt;i class="material-icons" aria-hidden="true"&gt;person_add&lt;/i&gt;Add user&lt;/a&gt;
&lt;a href="#"&gt;&lt;i class="at-user-plus small" aria-hidden="true"&gt;&lt;/i&gt;Add user&lt;/a&gt;


&lt;/div&gt;
Expand Down
10 changes: 5 additions & 5 deletions src/App/ComponentsDocumentation/components/ActionList/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@ import NpmInformation from "@docutils/NpmInformation";
const items = [
{
name: "Add bookmark",
icon: "bookmark",
icon: "at-bookmark-star",
},
{
name: "Add client",
icon: "business_center",
icon: "at-business-suitcase",
},
{
name: "Add document",
icon: "add_circle",
icon: "at-plus-circle",
},
{
name: "Add user",
icon: "person_add",
icon: "at-user-plus",
},
];

Expand Down Expand Up @@ -87,7 +87,7 @@ const ActionList = () => {
<DocContainer>
<Alert
type="danger"
icon="exclamation-triangle"
icon="swepay-icon-error-triangle-filled"
text={
<p>
<b>Deprecated:</b> Be aware, this component will not be maintained
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ exports[`Documentation: Alerts Content guidelines renders 1`] = `

<i
aria-hidden="true"
className="at-info-circle"
className="swepay-icon-info-circle-filled"
/>
<p>
<b>
Expand Down
Loading
Loading