feat: global config and default value #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweijie0812
requested review from
chaishi,
uyarn and
anlyyao
as code owners
uyarn
reviewed
Dec 25, 2024
| -- | -- | -- | -- | -- | ||
| attach | String / Function | 'body' | 制定挂载节点。数据类型为 String 时，会被当作选择器处理，进行节点查询。示例：'body' 或 () => document.body。TS 类型：`AttachNode`。[通用类型定义](https://github.com/Tencent/tdesign-react/blob/develop/src/common.ts) | N | ||
| attach | String / Function | - | 指定挂载节点。数据类型为 String 时，会被当作选择器处理，进行节点查询。示例：'body' 或 () => document.body。TS 类型：`AttachNode`。[通用类型定义](https://github.com/Tencent/tdesign-react/blob/develop/src/common.ts) | N |
There was a problem hiding this comment.
文档描述可能还是得体现默认是body
这个问题需要统一处理了，跟 closeOnOverlayClick 情况一样，仅文档体现默认值
There was a problem hiding this comment.
要跟Avatar size 一样描述吗
There was a problem hiding this comment.
还有一个方案 新增 doc_default_value 字段，用于配置文档显示的默认值， 文档显示默认值优先级 高于 field_default_value
There was a problem hiding this comment.
api 生成md 默认值处理，组件有全局配置同属性 ，组件属性默认值未定义会取全局配置的默认值 ,
例如。attach 在dialog组件 全局配置 DialogConfig 下，默认值body
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tencent/tdesign-react#3001
popup：attach 默认值移除