Unify reason attribute #2581
Open
Unify reason attribute #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydb
requested changes
Sep 5, 2024
There was a problem hiding this comment.
While the changes here are perfect if Council decides to go with teidata.word for all 5, I am against that idea. (I would prefer to see teidata.enumerated with a vocabulary list for all 5, and maybe see @reason factored out into a class of its own.)
See comments on issue itself.
|
Changed the datatype in question to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies all occurrences of the
reasonattribute, to useteidata.word.Closes #2580