Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and revised Japanese translation #2582

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from

Conversation

knagasaki
Copy link
Contributor

No description provided.

@ebeshero
Copy link
Member

ebeshero commented Oct 6, 2024

@martindholmes Would you take a look at this to review the translations? We also need to check with the conflict on the branch.

@joeytakeda joeytakeda added the i18n label Oct 6, 2024
@martindholmes
Copy link
Contributor

@ebeshero I'm not really competent to review the translations as such, of course, but I do look at the spreadsheet where the work is happening sometimes to see if there's anything doesn't seem right to me. I think the att.pointing conflict arises from the other work to add final periods to desc elements, affecting the French translation which comes right after the Japanese; the other one seems to be a whitespace change, possibly from the same work.

I do want to make a point of running another check for issue #2337 before the next release, so once this is merged, I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants