Skip to content

Conversation

@TaylorWatson
Copy link
Member

No description provided.

TaylorWatson and others added 2 commits October 8, 2025 20:55
… code

- Add nullable annotations to ITailBlazorTableModel interface properties (RowClass, ChildRowClass)
- Remove redundant using statements (now covered by ImplicitUsings)
- Remove redundant null check in OnParametersSet method

These changes improve null safety and leverage .NET 9 features more effectively.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +3 to +5
<table class="@Class">
<CascadingValue Value="this">
@ChildContent

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Cascade string literal instead of table instance

The CascadingValue now sets Value="this", which passes the literal string "this" rather than the current TailBlazorTable instance. Any child components that consume the cascading parameter (e.g., [CascadingParameter] TailBlazorTable table) will no longer receive the expected object and will either get a string or null, leading to runtime casting errors and broken access to table state. This should remain Value=this so the component instance is cascaded.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants