-
Notifications
You must be signed in to change notification settings - Fork 2
testing CC #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TaylorWatson
wants to merge
2
commits into
main
Choose a base branch
from
claude/review-net-upgrade-011CUK5BV8SGbXXwbicZZmZH
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
testing CC #3
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| namespace TailBlazor.Table | ||
| { | ||
| public interface ITailBlazorTableModel | ||
| { | ||
| string RowClass { get; } | ||
| string ChildRowClass { get; } | ||
| bool ShowChildTemplate { get; } | ||
| } | ||
| } | ||
| namespace TailBlazor.Table | ||
| { | ||
| public interface ITailBlazorTableModel | ||
| { | ||
| string? RowClass { get; } | ||
| string? ChildRowClass { get; } | ||
| bool ShowChildTemplate { get; } | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,42 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk.Razor"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net5.0</TargetFramework> | ||
| <PackageId>TailBlazor.Table</PackageId> | ||
| <RootNamespace>TailBlazor.Table</RootNamespace> | ||
| <Version>1.0.3</Version> | ||
| <Authors>Taylor Watson</Authors> | ||
| <IsPackage>true</IsPackage> | ||
| <PackageTags>Blazor; TailBlazorcss; TailBlazor css; tailwind; tailwindcss; Table; Tables;</PackageTags> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| <PackageProjectUrl>https://github.com/TailBlazor/Table</PackageProjectUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
| <RepositoryUrl>https://github.com/TailBlazor/Table</RepositoryUrl> | ||
| <Description> | ||
| A Blazor table component based off TailWindCss. It has the bare minimum styles to function with the option to add your own classes. It's built so it can be fully customizable and reusable for any table type. | ||
| </Description> | ||
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <PackageIcon>logo.png</PackageIcon> | ||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <SupportedPlatform Include="browser" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="5.0.1" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Include="../../logo.png" Pack="true" PackagePath=""> | ||
| <LinkBase>assets</LinkBase> | ||
| </None> | ||
| <None Include="../../LICENSE" Pack="true" PackagePath=""> | ||
| <LinkBase>assets</LinkBase> | ||
| </None> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
| <Project Sdk="Microsoft.NET.Sdk.Razor"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net9.0</TargetFramework> | ||
| <Nullable>enable</Nullable> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <PackageId>TailBlazor.Table</PackageId> | ||
| <RootNamespace>TailBlazor.Table</RootNamespace> | ||
| <Version>1.0.3</Version> | ||
| <Authors>Taylor Watson</Authors> | ||
| <IsPackage>true</IsPackage> | ||
| <PackageTags>Blazor; TailBlazorcss; TailBlazor css; tailwind; tailwindcss; Table; Tables;</PackageTags> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| <PackageProjectUrl>https://github.com/TailBlazor/Table</PackageProjectUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
| <RepositoryUrl>https://github.com/TailBlazor/Table</RepositoryUrl> | ||
| <Description> | ||
| A Blazor table component based off TailWindCss. It has the bare minimum styles to function with the option to add your own classes. It's built so it can be fully customizable and reusable for any table type. | ||
| </Description> | ||
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <PackageIcon>logo.png</PackageIcon> | ||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <SupportedPlatform Include="browser" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Include="../../logo.png" Pack="true" PackagePath=""> | ||
| <LinkBase>assets</LinkBase> | ||
| </None> | ||
| <None Include="../../LICENSE" Pack="true" PackagePath=""> | ||
| <LinkBase>assets</LinkBase> | ||
| </None> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| @namespace TailBlazor.Table | ||
|
|
||
| <table class="@Class"> | ||
| <CascadingValue Value=this> | ||
| @ChildContent | ||
| </CascadingValue> | ||
| </table> | ||
| @namespace TailBlazor.Table | ||
|
|
||
| <table class="@Class"> | ||
| <CascadingValue Value="this"> | ||
| @ChildContent | ||
| </CascadingValue> | ||
| </table> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,14 @@ | ||
| using System.Collections.Generic; | ||
| using Microsoft.AspNetCore.Components; | ||
|
|
||
| namespace TailBlazor.Table | ||
| { | ||
| public partial class TailBlazorTable | ||
| { | ||
| [Parameter] public RenderFragment ChildContent { get; set; } | ||
| [Parameter] public string Class { get; set; } = "min-w-full"; | ||
| } | ||
| } | ||
| using Microsoft.AspNetCore.Components; | ||
|
|
||
| namespace TailBlazor.Table | ||
| { | ||
| public partial class TailBlazorTable | ||
| { | ||
| [Parameter, EditorRequired] | ||
| public RenderFragment ChildContent { get; set; } = default!; | ||
|
|
||
| [Parameter] | ||
| public string Class { get; set; } = "min-w-full"; | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,31 @@ | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.AspNetCore.Components; | ||
|
|
||
| namespace TailBlazor.Table | ||
| { | ||
| public partial class TailBlazorTableBody<TItem> | ||
| where TItem : ITailBlazorTableModel | ||
| { | ||
| [Parameter] public RenderFragment<TItem> RowContent { get; set; } | ||
| [Parameter] public RenderFragment<TItem> ChildRowContent { get; set; } | ||
| [Parameter] public IEnumerable<TItem> Items { get; set; } | ||
| [Parameter] public string Class { get; set; } = "bg-white divide-y divide-gray-300"; | ||
| [Parameter] public bool StripeRows { get; set; } = true; | ||
| List<TItem> _items = new List<TItem>(); | ||
| [Parameter, EditorRequired] | ||
| public RenderFragment<TItem> RowContent { get; set; } = default!; | ||
|
|
||
| [Parameter] | ||
| public RenderFragment<TItem>? ChildRowContent { get; set; } | ||
|
|
||
| [Parameter] | ||
| public IEnumerable<TItem> Items { get; set; } = Array.Empty<TItem>(); | ||
|
|
||
| [Parameter] | ||
| public string Class { get; set; } = "bg-white divide-y divide-gray-300"; | ||
|
|
||
| [Parameter] | ||
| public bool StripeRows { get; set; } = true; | ||
|
|
||
| private List<TItem> _items = new(); | ||
|
|
||
| protected override void OnParametersSet() | ||
| { | ||
| _items = Items.ToList(); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,5 @@ | |
| <tr> | ||
| @ChildContent | ||
| </tr> | ||
| </thead> | ||
| </thead> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,14 @@ | ||
| using System.Collections.Generic; | ||
| using Microsoft.AspNetCore.Components; | ||
|
|
||
| namespace TailBlazor.Table | ||
| { | ||
| public partial class TailBlazorTableHeader | ||
| { | ||
| [Parameter] public RenderFragment ChildContent { get; set; } | ||
| [Parameter] | ||
| public RenderFragment? ChildContent { get; set; } | ||
|
|
||
| [Parameter] public string Class { get; set; } = "bg-gray-50"; | ||
| [Parameter] | ||
| public string Class { get; set; } = "bg-gray-50"; | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| @using Microsoft.AspNetCore.Components.Web | ||
| @using Microsoft.AspNetCore.Components.Web | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
CascadingValuenow setsValue="this", which passes the literal string"this"rather than the currentTailBlazorTableinstance. Any child components that consume the cascading parameter (e.g.,[CascadingParameter] TailBlazorTable table) will no longer receive the expected object and will either get a string ornull, leading to runtime casting errors and broken access to table state. This should remainValue=thisso the component instance is cascaded.Useful? React with 👍 / 👎.