Nawab: Fix the keyboard Interrupt #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is definitely a work around. But never a neat option. |
This commit fixes #58
iammarco11
force-pushed
the
Akshay-keyboard-interrupt
branch
from
255451d to
9b83f75
Compare
|
@Aniketh01 now I have fixed the other issue of |
|
This still looks a lot like a hacky way to fix the problem. Removing idle() seems to be not the right choice to me too. Please look into other ways if there is. Until then, I'm putting this PR on hold :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #58