[feat] 홈 뷰 앰플리튜드 트래킹 이벤트 코드 심기 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
reviewed
Sep 17, 2024
Comment on lines
125
to
128
| COURSE_LIST_ID to uiState.topLikedCourses.map { it.courseId }.joinToString() + "," + uiState.latestCourses.map { it.courseId }.joinToString(), | ||
| COURSE_LIST_TITLE to uiState.topLikedCourses.joinToString { it.title } + "," + uiState.latestCourses.joinToString { it.title }, | ||
| COURSE_LIST_LOCATION to uiState.topLikedCourses.joinToString { it.city } + "," + uiState.latestCourses.joinToString { it.city }, | ||
| COURSE_LIST_COST to uiState.topLikedCourses.joinToString { it.cost } + "," + uiState.latestCourses.joinToString { it.cost } |
There was a problem hiding this comment.
다른 스트링으로 바꾸긴 했는데 그거 추출했어요
There was a problem hiding this comment.
근데 궁금한게 string value에 해줘야할 지 Constaints에 해줘야할 지 고민하다 Constraints에 했는데 차이가 뭐야??
There was a problem hiding this comment.
주로 로직적인 부분에 사용되는 상수들을 관리할 때는 companion object 또는 object로 관리하고, UI와 관련된 문자열들을 관리할 때는 string value를 통해 관리합니당!
jihyunniiii
approved these changes
Sep 17, 2024
…home-amplitude # Conflicts: # app/src/main/java/org/sopt/dateroad/presentation/ui/home/HomeScreen.kt # app/src/main/java/org/sopt/dateroad/presentation/util/Constraints.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
코스 리스트
Uncompleted Tasks 😅
To Reviewers 📢
일단 어느 코스의 정보를 원하는지 몰라서 Hot 코스 리스트들의 정보를 넘깁니다.
-> new랑 hot 전부 원하시는것 같아 8개 전부 넘깁니다.( 스크린샷 참고 )