-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 홈 뷰 앰플리튜드 트래킹 이벤트 코드 심기 #260
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1169e37
[feat] #234 홈 뷰 앰플리튜드 이벤트, 프로퍼티 명 상수화
t1nm1ksun 0a1abc5
[feat] #234 홈 뷰 앰플리튜드 트래킹 코드 심기
t1nm1ksun fd1f3df
[chore] #234 코스 프로퍼티 new 코스 추가
t1nm1ksun 6d7dab9
[chore] #234 코스 리스트 프로퍼티 Hot, New 구분 스트링 추가
t1nm1ksun 0ec8898
[chore] #234 앰플리튜드 스트링 상수화
t1nm1ksun 7357529
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat-…
t1nm1ksun 276ffd3
[chore] #234 ktlintFormat
t1nm1ksun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추출 해줘잉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다른 스트링으로 바꾸긴 했는데 그거 추출했어요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
근데 궁금한게 string value에 해줘야할 지 Constaints에 해줘야할 지 고민하다 Constraints에 했는데 차이가 뭐야??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
주로 로직적인 부분에 사용되는 상수들을 관리할 때는 companion object 또는 object로 관리하고, UI와 관련된 문자열들을 관리할 때는 string value를 통해 관리합니당!