-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: High-level overview of Pirate Metrics params & signals #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
274ddd1
to
a95682f
Compare
a95682f
to
c98fd6e
Compare
3 tasks
winsmith
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I very much like how these functions are organized and named!
bdb8f5f
to
5d35f65
Compare
34d044d
to
060e013
Compare
Note that this commit was manually tested in a project and confirmed to work (persist, reset & count) as expected.
060e013
to
696a583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 This is a Work-in-Progress PR. Do not merge! 🚧
My goal with this PR was to get an high-level overview of all the things need to be done for the pirate metrics topic.
@winsmith Please have a look at this code. This is how I imagine the whole thing to look like at the end. Of course, many details are missing, including documentation and all the various TODOs.
But rather than sending you one huge PR at the end, I want you to review & approve this overview first (without merging it!). Then, I can tackle one TODO at a time and send you small PRs that finalize various aspects, which will all target this branch. When all TODOs are done, you will already have reviewed & approved all code and can take a last "overall" look if you want, before we merge it.
Let me know if you have any concerns with this approach and if you have any concerns with the overall approach I've outlined in this PR. Looking forward to your feedback! And excited for the feature. 😍
Extracted from the requirements comment here…
These 14 subtasks need to be handled before we can publish a first version of "Pirate Metrics" to users:
These tasks can be tackled after the release: