Fredrick/issue 314/git action integration

[iamfredrickokereke]

Hi Jeff,

Kindly check and review, I will make necessary corrections as required.

Thank you.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[jeff-knurek]

I guess the first thing that needs to be addressed is that it works on it's own:
https://github.com/TheIOFoundation/ProjectLockdown/pull/346/checks?check_run_id=2064650228

  env:
    AZURE_WEBAPP_NAME: your-app-name
    AZURE_WEBAPP_PACKAGE_PATH: .
Error: Unable to find Node version '10.x, 11.x, 12.x, 13.x, 14.x' for platform linux and architecture x64.

[jeff-knurek]

1 small change, and 1 bigger change please 🙏

[jeff-knurek]

this is interesting. it deploys in the previous step, and if successful auto-merges the code. but i don't think I like that approach. I'd rather only deploy if it is master. so maybe better to move this if statement to the previous deploy step, and so that we only deploy after the PR is closed and merged to master

[jeff-knurek]

the current build fails: https://github.com/TheIOFoundation/ProjectLockdown/pull/346/checks?check_run_id=2866537758

npm ERR! Invalid version: "2.0"

🤷 I'm not sure why

and I think you need to update your branch with the latest master so that the Netlify errors go away

[jeff-knurek]

I think this is all that is needed

Suggested change

	- if: github.ref == 'refs/heads/master' && job.status == 'success'
	run: |
	git push -u origin HEAD:master -f
	- name: "Deploy to Azure"
	uses: azure/webapps-deploy@v2
	- if: github.ref == 'refs/heads/master' && job.status == 'success'
	name: "Deploy to Azure"
	uses: azure/webapps-deploy@v2

[iamfredrickokereke]

Okay I will correct it now, sorry I did not get any notification on my mail, hence my delayed response.

[netlify]

✔️ Deploy Preview for dazzling-visvesvaraya-f47271 ready!

🔨 Explore the source changes: e09ab9b

🔍 Inspect the deploy log: https://app.netlify.com/sites/dazzling-visvesvaraya-f47271/deploys/60d09bd706ce030008206ef6

😎 Browse the preview: https://deploy-preview-346--dazzling-visvesvaraya-f47271.netlify.app

[iamfredrickokereke]

This works now, however, the test script in the API directory failed as shown attached:

[iamfredrickokereke]

New changes updated

[jeff-knurek]

there's a couple dependencies that changed in the package.json file. the only change should be the 2.0.0 change

[iamfredrickokereke]

Recent changes updated now.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[squash-labs]

Manage this branch in Squash

Test this branch here: https://fredrickissue-314git-action-in-vs2c7.squash.io