Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fredrick/issue 314/git action integration #346
base: master
Are you sure you want to change the base?
Fredrick/issue 314/git action integration #346
Changes from 9 commits
5b5ffd8
7dcac5e
1f0a03c
89f1215
0bcef7c
7ad22c5
e8d491c
9c17a85
1111eb2
573edbc
d0e35cc
e09ab9b
24dcca2
6a7e8c7
961765b
40b0436
6a22b8c
3daccc6
a545357
da401ff
0810ad2
ce0ab0f
8f1a102
65c3eff
674f55d
f5bcae8
976b18c
bf2b1c0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is interesting. it deploys in the previous step, and if successful auto-merges the code. but i don't think I like that approach. I'd rather
only
deploy if it is master. so maybe better to move thisif
statement to the previous deploy step, and so that we only deploy after the PR is closed and merged to master