Added description on the profile page#100
Closed
Iwueseiter wants to merge 2 commits intoTheSoftwareDevGuild:mainfrom
Closed
Added description on the profile page#100Iwueseiter wants to merge 2 commits intoTheSoftwareDevGuild:mainfrom
Iwueseiter wants to merge 2 commits intoTheSoftwareDevGuild:mainfrom
Conversation
Iwueseiter
requested review from
Teddy1792,
joelamouche and
oscarwroche
as code owners
joelamouche
requested changes
Oct 7, 2025
| type Props = { address?: string }; | ||
|
|
||
| export default function ProfilePage({ address }: Props) { | ||
| const profilesQuery = useGetProfiles(); |
Contributor
There was a problem hiding this comment.
Ok so this won't work because AppWrapper, which injects query client is in this component. Instead, you should create a new component ProfileMain.tsx in components/profiles/profile-page with the content of AppWrapper here and then use the hook at this level.
OR
move AppWrapper to frontend/src/pages/profiles/[address].astro (probable better? if that works?)
So while you are at it, please remove the same logic in ProfileHeader and inject name and description into ProfileHeader from ProfileMain using props
Contributor
There was a problem hiding this comment.
ProfileMain was implemented in #98 so please rebase with main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a component to display profile descriptions on the zoomed profile page, positioned between action buttons and attestations.
Updated Create/Edit profile dialogs to use a larger textarea for the description field, allowing multiline input.
Ensured profile descriptions are shown where necessary.
Closes #49