build(debug): Add CMake option RTS_DEBUG_CHEATS to enable debug cheats in release builds

[bobtista]

• closes Implement CMake option for _ALLOW_DEBUG_CHEATS_IN_RELEASE #1335

Summary

Implements a CMake option RTS_DEBUG_CHEATS to control debug cheat availability in release builds, replacing the manual DONT_ALLOW_DEBUG_CHEATS_IN_RELEASE define in GameCommon.h.

Usage

# Enable debug cheats in release builds
cmake -DRTS_DEBUG_CHEATS=ON ..

# Disable debug cheats in release builds (default)
cmake -DRTS_DEBUG_CHEATS=OFF ..

[greptile-apps]

Greptile Overview

Greptile Summary

This PR modernizes debug cheat configuration by replacing a manual header define with a proper CMake build option.

Changes

• Removed the manual DONT_ALLOW_DEBUG_CHEATS_IN_RELEASE define from GameCommon.h
• Added RTS_DEBUG_CHEATS CMake option (OFF by default) in config-debug.cmake
• When enabled, defines _ALLOW_DEBUG_CHEATS_IN_RELEASE to unlock debug cheats in release builds

Behavior

The default behavior is preserved: debug cheats remain disabled in release builds unless explicitly enabled via -DRTS_DEBUG_CHEATS=ON. This replaces the previous approach of manually editing the header file to toggle the DONT_ prefix.

Confidence Score: 5/5

• This PR is safe to merge - it's a clean refactoring with no functional changes to default behavior
• The changes correctly preserve existing semantics while improving configurability. The default OFF state matches the previous behavior of disallowing debug cheats in release builds. The implementation follows existing CMake patterns in the file.
• No files require special attention

Important Files Changed

Filename	Overview
Core/GameEngine/Include/Common/GameCommon.h	Removed manual DONT_ALLOW_DEBUG_CHEATS_IN_RELEASE define - now controlled by CMake
cmake/config-debug.cmake	Added RTS_DEBUG_CHEATS option (OFF by default) that defines _ALLOW_DEBUG_CHEATS_IN_RELEASE when enabled

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CMake as CMake Build System
    participant Config as config-debug.cmake
    participant Target as core_config
    participant Code as Game Code

    Dev->>CMake: cmake -DRTS_DEBUG_CHEATS=OFF (default)
    CMake->>Config: Process config-debug.cmake
    Config->>Config: Check RTS_DEBUG_CHEATS option
    Note over Config: RTS_DEBUG_CHEATS=OFF
    Config-->>Target: No _ALLOW_DEBUG_CHEATS_IN_RELEASE defined
    Target->>Code: Compile without debug cheats
    Note over Code: Debug cheats disabled in release

    Dev->>CMake: cmake -DRTS_DEBUG_CHEATS=ON
    CMake->>Config: Process config-debug.cmake
    Config->>Config: Check RTS_DEBUG_CHEATS option
    Note over Config: RTS_DEBUG_CHEATS=ON
    Config->>Target: Define _ALLOW_DEBUG_CHEATS_IN_RELEASE
    Target->>Code: Compile with debug cheats
    Note over Code: Debug cheats enabled in release

Loading

[xezon]

@greptileai

[xezon]

Looks good