Skip to content

Conversation

@bobtista
Copy link

Fix spelling errors in code comments.

@greptile-apps
Copy link

greptile-apps bot commented Jan 18, 2026

Greptile Summary

This PR corrects spelling errors in code comments across 83 files spanning Core, Generals game engine, device implementations, libraries, and tools. All changes are purely documentation improvements with no functional code modifications.

  • Fixed common misspellings: "specifc" → "specific", "propogated" → "propagated", "addtional" → "additional", "efficienty" → "efficiently", "funcitons" → "functions", "heirarchy" → "hierarchy", "sytem" → "system", "implemtation" → "implementation", among others
  • Changes affect header files (.h), source files (.cpp), across multiple subsystems: audio, networking, UI, rendering (W3D), particle systems, shadow volumes, terrain, and editor tools
  • All modifications are in comment blocks only - no logic, API, or behavior changes

Confidence Score: 5/5

  • This PR is safe to merge with zero risk
  • All changes are spelling corrections in comments only. No functional code, logic, or behavior is modified. The changes improve documentation quality without any possibility of introducing bugs or breaking changes
  • No files require special attention

Important Files Changed

Filename Overview
Core/GameEngine/Include/Common/AudioEventRTS.h Fixed spelling: "specifc" → "specific" in comment
Generals/Code/GameEngine/Include/Common/Energy.h Fixed spelling: "INLCUDES" → "INCLUDES" in comment header
Generals/Code/GameEngine/Include/GameClient/GameWindow.h Fixed multiple spellings: "propogated" → "propagated", "addtional" → "additional", "sytem" → "system", "heirarchy" → "hierarchy", "piont" → "point", "reguardless" → "regardless"
Generals/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DGadget.h Fixed spelling: "Implemtation" → "Implementation" in comment
Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/Shadow/W3DVolumetricShadow.cpp Fixed spellings: "efficienty" → "efficiently", "onces" → "ones", "columes" → "columns" in comments
Generals/Code/Libraries/Source/WWVegas/WW3D2/camera.h Fixed spelling: "funcitons" → "functions" in comment
Generals/Code/Tools/GUIEdit/Include/GUIEdit.h Fixed spelling: "entrys" → "entries" in comment

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Files as 83 Source Files
    participant Comments as Code Comments
    
    Dev->>Files: Identify spelling errors
    Note over Files: Across Core, Generals,<br/>Libraries, and Tools
    
    loop For each of 83 files
        Dev->>Comments: Read comment text
        Comments->>Dev: Return misspelled words
        Dev->>Comments: Fix spelling errors
        Note over Comments: No code logic changed<br/>Only comment text updated
    end
    
    Dev->>Files: Save corrected comments
    Note over Files: 108 lines changed<br/>(108 insertions, 108 deletions)
Loading

@xezon xezon added the Documentation Is documentation or complementary resource label Jan 19, 2026
@bobtista bobtista force-pushed the fix/typos-include-device-libs-tools branch from 52e144d to 9a95d76 Compare January 19, 2026 21:12
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daily dose of Bobtista changes

@xezon
Copy link

xezon commented Jan 22, 2026

I do not understand the splitting of this change. The title claims one thing, but the actual changes files are in all sorts of unrelated folders that do correspond to what the title says.

@bobtista bobtista changed the title docs: Fix spelling errors in Include, GameEngineDevice, Libraries, and Tools comments docs: Fix spelling errors in Core and Generals/Include/GameEngineDevice/Libraries/Tools comments Jan 22, 2026
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

120 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Comment on lines 4033 to 4042
// Everybody chills when they captured so they don't keep doing something the new player might not want him to be doing
// TheSuperHackers @tweak Stubbjax 19/11/2025 Except when the new owner is an ally, so that Hackers keep on hacking, etc.
if( getAIUpdateInterface() && (oldOwner != newOwner) )
{
#if RETAIL_COMPATIBLE_CRC
getAIUpdateInterface()->aiIdle(CMD_FROM_AI);
#else
if (oldOwner->getRelationship(newOwner->getDefaultTeam()) != ALLIES)
getAIUpdateInterface()->aiIdle(CMD_FROM_AI);
#endif
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: This PR's title and description indicate it's only fixing spelling errors in comments, but this includes actual logic changes (new conditional behavior for allies). Consider splitting logic changes into a separate PR.

Suggested change
// Everybody chills when they captured so they don't keep doing something the new player might not want him to be doing
// TheSuperHackers @tweak Stubbjax 19/11/2025 Except when the new owner is an ally, so that Hackers keep on hacking, etc.
if( getAIUpdateInterface() && (oldOwner != newOwner) )
{
#if RETAIL_COMPATIBLE_CRC
getAIUpdateInterface()->aiIdle(CMD_FROM_AI);
#else
if (oldOwner->getRelationship(newOwner->getDefaultTeam()) != ALLIES)
getAIUpdateInterface()->aiIdle(CMD_FROM_AI);
#endif
// Everybody chills when they captured so they don't keep doing something the new player might not want him to be doing
if( getAIUpdateInterface() && (oldOwner != newOwner) )
getAIUpdateInterface()->aiIdle(CMD_FROM_AI);

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: Generals/Code/GameEngine/Source/GameLogic/Object/Object.cpp
Line: 4033:4042

Comment:
**logic:** This PR's title and description indicate it's only fixing spelling errors in comments, but this includes actual logic changes (new conditional behavior for allies). Consider splitting logic changes into a separate PR.

```suggestion
	// Everybody chills when they captured so they don't keep doing something the new player might not want him to be doing
	if( getAIUpdateInterface()  &&  (oldOwner != newOwner) )
		getAIUpdateInterface()->aiIdle(CMD_FROM_AI);
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

Comment on lines 4555 to 4564
// Everybody chills when they captured so they don't keep doing something the new player might not want him to be doing
// TheSuperHackers @tweak Stubbjax 19/11/2025 Except when the new owner is an ally, so that Hackers keep on hacking, etc.
if( getAIUpdateInterface() && (oldOwner != newOwner) )
{
#if RETAIL_COMPATIBLE_CRC
getAIUpdateInterface()->aiIdle(CMD_FROM_AI);
#else
if (oldOwner->getRelationship(newOwner->getDefaultTeam()) != ALLIES)
getAIUpdateInterface()->aiIdle(CMD_FROM_AI);
#endif
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Same as Generals version - logic changes should be in a separate PR from documentation fixes.

Suggested change
// Everybody chills when they captured so they don't keep doing something the new player might not want him to be doing
// TheSuperHackers @tweak Stubbjax 19/11/2025 Except when the new owner is an ally, so that Hackers keep on hacking, etc.
if( getAIUpdateInterface() && (oldOwner != newOwner) )
{
#if RETAIL_COMPATIBLE_CRC
getAIUpdateInterface()->aiIdle(CMD_FROM_AI);
#else
if (oldOwner->getRelationship(newOwner->getDefaultTeam()) != ALLIES)
getAIUpdateInterface()->aiIdle(CMD_FROM_AI);
#endif
// Everybody chills when they captured so they don't keep doing something the new player might not want him to be doing
if( getAIUpdateInterface() && (oldOwner != newOwner) )
getAIUpdateInterface()->aiIdle(CMD_FROM_AI);

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp
Line: 4555:4564

Comment:
**logic:** Same as Generals version - logic changes should be in a separate PR from documentation fixes.

```suggestion
	// Everybody chills when they captured so they don't keep doing something the new player might not want him to be doing
	if( getAIUpdateInterface()  &&  (oldOwner != newOwner) )
		getAIUpdateInterface()->aiIdle(CMD_FROM_AI);
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

@bobtista
Copy link
Author

I do not understand the splitting of this change. The title claims one thing, but the actual changes files are in all sorts of unrelated folders that do correspond to what the title says.

I think it's because there were multiple commits, and main has changed, I bet if I rebase and squash it's clean

@bobtista bobtista force-pushed the fix/typos-include-device-libs-tools branch from 009d817 to e5ef95a Compare January 22, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Is documentation or complementary resource

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants