Skip to content

perf(particlesys): Optimize angleBetween() in Particle System #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xezon wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

perf(particlesys): Optimize angleBetween() in Particle System #2218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions Core/GameEngine/Source/GameClient/System/ParticleSys.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3454,16 +3454,17 @@ void ParticleSystemDebugDisplay( DebugDisplayInterface *dd, void *, FILE *fp )
// ------------------------------------------------------------------------------------------------
static Real angleBetween(const Coord2D *vecA, const Coord2D *vecB)
{
if (!(vecA && vecA->length() && vecB && vecB->length())) {
return 0.0;
const Real lengthA = vecA->length();
const Real lengthB = vecB->length();

if (!(lengthA && lengthB)) {
Copy link

@Mauller Mauller Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be !(vecA || vecB) before their use, or can they not be null at any point?

Copy link
Author

@xezon xezon Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I looked at call sites and they were not null, so I omitted null tests. I can relook.

return 0.0f;
}

Real lengthA = vecA->length();
Real lengthB = vecB->length();
Real dotProduct = (vecA->x * vecB->x + vecA->y * vecB->y);
Real cosTheta = dotProduct / (lengthA * lengthB);

// If the dotproduct is 0.0, then they are orthogonal
// If the dot product is 0.0, then they are orthogonal
if (dotProduct == 0.0f) {
if (vecB->x > 0) {
return PI;
Expand Down
Loading