-
Notifications
You must be signed in to change notification settings - Fork 88
Add Posit Support to PyRTL #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Add Posit Support to PyRTL #473
Conversation
|
Thank you for submitting this pull request! It looks very interesting, but I am unfamiliar with Posits, and I will be away next week, so it will take me some time to review these commits. In the meantime, the pull request checks point to some code style issues that will need to be addressed. Don't worry about any reported issues in code that you haven't changed in your pull request, I will look into that separately. I don't yet know what's happening there, Thanks again, and thank you for your patience while I review this pull request! |
Ah, |
|
Commit 8c706f6 should fix the pre-existing code style issues, so you should update your fork and rebase to see only the code style issues in your PR. Sorry for the noise, I will try to improve pyrtl's testing workflows so this doesn't happen in the future. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #473 +/- ##
=============================================
+ Coverage 91.0% 91.1% +0.1%
=============================================
Files 25 29 +4
Lines 7091 7384 +293
=============================================
+ Hits 6450 6722 +272
- Misses 641 662 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for the PR arvindajaybharadwaj, it is really cool to learn about Posits -- I was not aware of this format. I had a chance to read through your PR and we are open in theory bringing this into pyrtl, it could be a nice addition to rtllib, but there is a bit of work that would be required here to finalize the test and bring it into the preferred pyrtl style of python. If you are interested to do this work to see it in pyrtl let us know and we can start scoping it out in more detail. If not, we are happy to link to your project somewhere else in case anyone is trying to find a library on this. Thanks for working on cool hardware in python with us! |
This PR adds Posit number format support to PyRTL, including configurable nbits and es and basic arithmetic operations (addition, multiplication, and matmul).