Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DTFS2-7621): add amendments url helper #4141

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

BethThomas141
Copy link
Contributor

@BethThomas141 BethThomas141 commented Jan 15, 2025

Introduction ✏️

We've written out the URL for different amendments pages a lot over the amendments controllers. This new helper reduces some of the repetition.

Resolution ✔️

  • Add amendments URL helper to avoid having to keep hardcoding amendments URL strings.
  • Add correct cancel URL to What needs to change? page inline with the other pages in the flow
  • Convert the component test for What needs to change? page to Typescript, consistent with the other pages in the flow

Miscellaneous ➕

List any additional fixes or improvements.

@BethThomas141 BethThomas141 merged commit d125a16 into main Jan 16, 2025
237 of 238 checks passed
@BethThomas141 BethThomas141 deleted the feat/DTFS2-7621/amendments-url-helper branch January 16, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants