Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DTFS2-7621): add amendments url helper #4141

Merged
merged 5 commits into from
Jan 16, 2025

feat(DTFS2-7621): update cancel urls in test files

4472963
Select commit
Loading
Failed to load commit list.
Merged

feat(DTFS2-7621): add amendments url helper #4141

feat(DTFS2-7621): update cancel urls in test files
4472963
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jan 16, 2025 in 0s

19 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 19
           

Complexity increasing per file
==============================
- gef-ui/server/controllers/amendments/helpers/navigation.helper.getAmendmentsUrl.test.ts  1
- gef-ui/component-tests/partials/amendments/what-needs-to-change.component-test.ts  1
         

Clones added
============
- gef-ui/component-tests/partials/amendments/what-needs-to-change.component-test.ts  12
- gef-ui/server/controllers/amendments/what-needs-to-change/get-what-needs-to-change.test.ts  2
- gef-ui/server/controllers/amendments/what-needs-to-change/get-what-needs-to-change.ts  1
- gef-ui/server/controllers/amendments/what-needs-to-change/post-what-needs-to-change.ts  1

See the complete overview on Codacy

Annotations

Check failure on line 63 in gef-ui/server/controllers/amendments/bank-review-date/get-bank-review-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/bank-review-date/get-bank-review-date.ts#L63 

Unsafe assignment of an error typed value.

Check failure on line 46 in gef-ui/server/controllers/amendments/cover-end-date/get-cover-end-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cover-end-date/get-cover-end-date.ts#L46 

Unsafe assignment of an error typed value.

Check failure on line 51 in gef-ui/server/controllers/amendments/cover-end-date/get-cover-end-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cover-end-date/get-cover-end-date.ts#L51 

Unsafe assignment of an error typed value.

Check failure on line 24 in gef-ui/server/controllers/amendments/create-draft/post-create-draft.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/create-draft/post-create-draft.ts#L24 

Unsafe assignment of an error typed value.

Check failure on line 46 in gef-ui/server/controllers/amendments/do-you-have-a-facility-end-date/get-do-you-have-a-facility-end-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/do-you-have-a-facility-end-date/get-do-you-have-a-facility-end-date.ts#L46 

Unsafe assignment of an error typed value.

Check failure on line 53 in gef-ui/server/controllers/amendments/do-you-have-a-facility-end-date/get-do-you-have-a-facility-end-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/do-you-have-a-facility-end-date/get-do-you-have-a-facility-end-date.ts#L53 

Unsafe assignment of an error typed value.

Check failure on line 40 in gef-ui/server/controllers/amendments/do-you-have-a-facility-end-date/post-do-you-have-a-facility-end-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/do-you-have-a-facility-end-date/post-do-you-have-a-facility-end-date.ts#L40 

Unsafe assignment of an error typed value.

Check failure on line 47 in gef-ui/server/controllers/amendments/facility-end-date/get-facility-end-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/facility-end-date/get-facility-end-date.ts#L47 

Unsafe assignment of an error typed value.

Check failure on line 52 in gef-ui/server/controllers/amendments/facility-end-date/get-facility-end-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/facility-end-date/get-facility-end-date.ts#L52 

Unsafe assignment of an error typed value.

Check failure on line 59 in gef-ui/server/controllers/amendments/facility-end-date/get-facility-end-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/facility-end-date/get-facility-end-date.ts#L59 

Unsafe assignment of an error typed value.

Check failure on line 47 in gef-ui/server/controllers/amendments/facility-value/get-facility-value.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/facility-value/get-facility-value.ts#L47 

Unsafe assignment of an error typed value.

Check failure on line 57 in gef-ui/server/controllers/amendments/facility-value/get-facility-value.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/facility-value/get-facility-value.ts#L57 

Unsafe assignment of an error typed value.

Check failure on line 47 in gef-ui/server/controllers/amendments/facility-value/post-facility-value.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/facility-value/post-facility-value.ts#L47 

Unsafe assignment of an error typed value.

Check failure on line 85 in gef-ui/server/controllers/amendments/helpers/navigation.helper.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/helpers/navigation.helper.ts#L85 

Unsafe assignment of an error typed value.

Check failure on line 86 in gef-ui/server/controllers/amendments/helpers/navigation.helper.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/helpers/navigation.helper.ts#L86 

Unsafe assignment of an error typed value.

Check failure on line 88 in gef-ui/server/controllers/amendments/helpers/navigation.helper.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/helpers/navigation.helper.ts#L88 

Unsafe assignment of an error typed value.

Check failure on line 106 in gef-ui/server/controllers/amendments/helpers/navigation.helper.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/helpers/navigation.helper.ts#L106 

Unsafe assignment of an error typed value.

Check failure on line 49 in gef-ui/server/controllers/amendments/what-needs-to-change/get-what-needs-to-change.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/what-needs-to-change/get-what-needs-to-change.ts#L49 

Unsafe assignment of an error typed value.

Check failure on line 44 in gef-ui/server/controllers/amendments/what-needs-to-change/post-what-needs-to-change.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/what-needs-to-change/post-what-needs-to-change.ts#L44 

Unsafe assignment of an error typed value.
View more details on Codacy Production