Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DTFS2-7793): add update amendment status endpoint to dtfs-central #4193

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

MarRobSoftwire
Copy link
Contributor

@MarRobSoftwire MarRobSoftwire commented Jan 30, 2025

Introduction ✏️

The Maker needs to be able to submit the amendment to the Checker

Resolution ✔️

  • Add update portal amendment status endpoint
  • Add PortalFacilityAmendmentService.submitPortalFacilityAmendmentToChecker service method
  • Add PortalFacilityAmendmentService.validateAmendmentIsComplete to verify the amendment can be submitted
    • This throws new AmendmentIncompleteError returning a 409 - conflict

Miscellaneous ➕

  • Abstract PortalFacilityAmendmentService.updatePortalFacilityAmendment logic so only user values properties can be updated
  • Add PortalFacilityAmendmentService.generatePortalFacilityAmendment mapping to keep portal facility amendments in valid shape
  • Update TfmFacilitiesRepo.updatePortalFacilityAmendmentByAmendmentId to validate the status of the amendment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants