feat(DTFS2-7793): add update amendment status endpoint to dtfs-central #4193
Codacy Production / Codacy Static Code Analysis
required action
Feb 7, 2025 in 0s
4 new issues (0 max.) of at least minor severity.
Issues
======
+ Solved 32
- Added 4
Complexity increasing per file
==============================
- dtfs-central-api/src/v1/routes/middleware/payload-validation/validate-patch-portal-facility-amendment-status-payload.test.ts 1
- dtfs-central-api/api-tests/v1/portal-facility-amendments/amendment-status-patch.api-test.ts 1
- dtfs-central-api/src/v1/controllers/portal/facility/patch-amendment-status.controller.test.ts 1
- dtfs-central-api/src/v1/controllers/portal/facility/patch-amendment-status.controller.ts 4
- dtfs-central-api/src/services/portal/facility-amendment.generatePortalFacilityAmendment.service.test.ts 1
- dtfs-central-api/src/services/portal/facility-amendment.validateAmendmentIsComplete.service.test.ts 1
- dtfs-central-api/src/services/portal/facility-amendment.updatePortalFacilityAmendmentUserValues.service.test.ts 1
- gef-ui/server/controllers/amendments/do-you-have-a-facility-end-date/get-do-you-have-a-facility-end-date.ts 1
- dtfs-central-api/api-tests/helpers/create-portal-facility-amendment.ts 1
- dtfs-central-api/src/services/portal/facility-amendment.service.ts 18
Clones added
============
- dtfs-central-api/src/v1/routes/middleware/payload-validation/validate-patch-portal-facility-amendment-status-payload.test.ts 2
- dtfs-central-api/api-tests/v1/portal-facility-amendments/amendment-status-patch.api-test.ts 22
- dtfs-central-api/src/v1/controllers/portal/facility/patch-amendment-status.controller.test.ts 14
- dtfs-central-api/src/v1/controllers/portal/facility/patch-amendment-status.controller.ts 1
- dtfs-central-api/src/services/portal/facility-amendment.generatePortalFacilityAmendment.service.test.ts 1
- dtfs-central-api/src/services/portal/facility-amendment.validateAmendmentIsComplete.service.test.ts 5
- dtfs-central-api/src/services/portal/facility-amendment.updatePortalFacilityAmendmentUserValues.service.test.ts 8
- dtfs-central-api/src/services/portal/facility-amendment.submitPortalFacilityAmendmentToChecker.service.test.ts 7
- portal-api/src/v1/validation/route-validators/amendments/validate-put-portal-facility-amendment-payload.test.ts 1
- dtfs-central-api/src/v1/controllers/portal/facility/patch-amendment.controller.test.ts 3
- dtfs-central-api/api-tests/v1/portal-facility-amendments/amendment-patch.api-test.ts 2
- dtfs-central-api/src/services/portal/facility-amendment.service.ts 2
- dtfs-central-api/src/repositories/tfm-facilities-repo/tfm-facilities.repo.ts 1
Clones removed
==============
+ dtfs-central-api/src/repositories/tfm-facilities-repo/tfm-facilities.repo.updatePortalFacilityAmendmentByAmendmentId.test.ts -3
See the complete overview on Codacy
Annotations
codacy-production / Codacy Static Code Analysis
dtfs-central-api/src/services/portal/facility-amendment.validateNoOtherAmendmentsUnderWayOnDeal.service.test.ts#L77
Unsafe assignment of an error typed value.
codacy-production / Codacy Static Code Analysis
dtfs-central-api/src/services/portal/facility-amendment.validateNoOtherAmendmentsUnderWayOnDeal.service.test.ts#L77
Unsafe call of an `error` type typed value.
codacy-production / Codacy Static Code Analysis
dtfs-central-api/src/services/portal/facility-amendment.validateNoOtherAmendmentsUnderWayOnDeal.service.test.ts#L77
Unsafe member access .amendmentId on an `error` typed value.
codacy-production / Codacy Static Code Analysis
dtfs-central-api/src/services/portal/facility-amendment.validateNoOtherAmendmentsUnderWayOnDeal.service.test.ts#L83
Unsafe assignment of an error typed value.
Loading