Skip to content

feat(EMS-4011-4115): policy - check your answers - broker address #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 13, 2025

Conversation

ttbarnes
Copy link
Contributor

Introduction ✏️

This PR updates the "check your answers" functionality for the "Policy - Check your answers" form, to support the SELECT_THE_ADDRESS and FULL_ADDRESS fields, depending on if IS_BASED_IN_UK is true.

Note: This PR does include E2E coverage for changing the answer or the UK/non-UK differences. These will be added in the next PR.

Resolution ✔️

  • Update checkPolicySummaryList E2E command.
  • Add new check/change routes.
  • Update field content strings.
  • Update the following UI post controllers to redirect to CHECK_YOUR_ANSWERS if the URL is a "change" route:
    • Broker addresses
    • Broker manual address
  • Add mapBrokerAddressBasedInTheUk helper function to the UI.
  • Update policy summary list logic:
    • Create new brokerAddressField function.
    • Update optionalBrokerFields to call brokerAddressField.

Miscellaneous ➕

  • Address some TODO comments.
  • Minor documentation improvements.

@ttbarnes ttbarnes added documentation Improvements or additions to documentation enhancement New feature or request feature New functionality tech Technical debt/improvements chore Chore labels Jan 13, 2025
@ttbarnes ttbarnes self-assigned this Jan 13, 2025
@abhi-markan abhi-markan merged commit 6f3b9d8 into main-broker-address-lookup Jan 13, 2025
185 of 186 checks passed
@abhi-markan abhi-markan deleted the feat/EMS-4011-4115 branch January 13, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore documentation Improvements or additions to documentation enhancement New feature or request feature New functionality tech Technical debt/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants