-
Notifications
You must be signed in to change notification settings - Fork 1
feat(EMS-4011-4115): policy - check your answers - broker address #3474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-markan
approved these changes
Jan 13, 2025
6f3b9d8
into
main-broker-address-lookup
185 of 186 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Chore
documentation
Improvements or additions to documentation
enhancement
New feature or request
feature
New functionality
tech
Technical debt/improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR updates the "check your answers" functionality for the "Policy - Check your answers" form, to support the
SELECT_THE_ADDRESS
andFULL_ADDRESS
fields, depending on ifIS_BASED_IN_UK
is true.Note: This PR does include E2E coverage for changing the answer or the UK/non-UK differences. These will be added in the next PR.
Resolution ✔️
checkPolicySummaryList
E2E command.CHECK_YOUR_ANSWERS
if the URL is a "change" route:mapBrokerAddressBasedInTheUk
helper function to the UI.brokerAddressField
function.optionalBrokerFields
to callbrokerAddressField
.Miscellaneous ➕