Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L-06 [Oval] CoinbaseSourceAdapter May Return Old Prices #24

Conversation

Reinis-FRP
Copy link
Collaborator

Addresses audit issue: L-06 [Oval] CoinbaseSourceAdapter May Return Old Prices

In order to limit the staleness of the data returned by source adapters, the maxAge function
has been introduced. It defines the maximum age of prices that can be returned by the
tryLatestDataAt function. However, the CoinbaseSourceAdapter does not use the
maxAge function when it returns historical data as other adapters do. This means that it can
possibly return very old prices.

Consider limiting the staleness of the data returned by the CoinbaseSourceAdapter by
utilizing the maxAge function.

This implements the recommended fix by utilizing the maxAge function in CoinbaseSourceAdapter.

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link

linear bot commented Jun 17, 2024

@Reinis-FRP Reinis-FRP requested review from chrismaree and md0x June 17, 2024 14:20
@Reinis-FRP Reinis-FRP merged commit 70e5b66 into master Jun 18, 2024
3 checks passed
@Reinis-FRP Reinis-FRP deleted the reinis/uma-2651-l-06-oval-coinbasesourceadapter-may-return-old-prices branch June 18, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants