Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L-06 [Oval] CoinbaseSourceAdapter May Return Old Prices #24

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/adapters/source-adapters/CoinbaseSourceAdapter.sol
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ abstract contract CoinbaseSourceAdapter is DiamondRootOval {
// Attempt traversing historical round data backwards from roundId.
(int256 historicalAnswer, uint256 historicalUpdatedAt) = _searchRoundDataAt(timestamp, roundId, maxTraversal);

// Validate returned data. If it is uninitialized, fall back to returning the current latest round data.
if (historicalUpdatedAt > 0) {
// Validate returned data. If it is uninitialized or too old, fall back to returning the current latest round data.
if (historicalUpdatedAt > block.timestamp - maxAge()) {
return (historicalAnswer, historicalUpdatedAt);
}

Expand Down
Loading