N-14 [Oval] Possible Duplicate Event Emission

[Reinis-FRP]

Addresses audit issue: N-14 [Oval] Possible Duplicate Event Emission

When a setter function does not check if the value has changed, it opens up the possibility of
spamming events indicating that the value has changed when it has not. Spamming the same
values can potentially confuse off-chain clients.

Within MutableUnlockersController.sol , the setUnlocker function sets the
unlockers state variable and emits an event without checking if the value has changed.

Consider adding a check to revert the transaction if the value remains unchanged.

This implements the recommended fix by requiring unlockers state to be changed when calling setUnlocker in mutable controllers.

[linear]

UMA-2656 N-14 [Oval] Possible Duplicate Event Emission

[md0x]

LGTM

[chrismaree]

this is silly feedback as only the owner can make this change. an alternative(you don't have to change it) would be to only emit if there is a diff that way it does not revert and we don't pollute the logs. either way, this is fine.