TADA_CreateParamRef() and TADA_CreateParamUseRef() #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First 2 reference files draft functions have been pushed through.
|
working on addressing some check issues that were found |
TADA_CreateParamRef and TADA_CreateParamUseRef .RD files
removal of some intermediate objects
Update - only print df if there are failing URLs
documentation suggestions
hillarymarler
requested changes
Dec 17, 2024
Added a tab for org_name filtered paramter and use names from ATTAINS Modified return values of ATTAINS.FlagParameterName
|
@cristinamullin @hillarymarler There are still some edits and formatting I would like to make, but I think this is in a good spot to review now. I will be out of the office tomorrow but will be back on Friday the 20th. |
…/USEPA/EPATADA into Create-Module-3-Reference-Tables
Changed name to identifier where applicable. Updated some flagging functions Updates to vignette
Data_6Tribes_5y_Harmonized is showing TADA.ComparableDataIdentifier as PH_NA_NA_NA. Did we decide on if we wanted it all to be harmonized to PH_NA_NA_STD UNITS or PH_NA_NA_NA?
Update to .Rd documents Updates to global variables
Updated minor excel output bug, and updated documentation for greater clarity in Mod 3 functions.
consolidate ATTAINS functions into one .R
fix mod 3, update example data and ref tables
|
@wokenny13 can you look into this check note? ❯ checking R code for possible problems ... [18s] NOTE
TADA_GetEPA304aRef: no visible binding for global variable 'UNIT_NAME'
Undefined global functions or variables:
UNIT_NAME |
Made code more concise and readable. Reduced lines to less than 100 characters global variable update.
pkgdown currently only supports html format
qmd is not supported by pkgdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First 2 reference files draft functions have been pushed through to test.
I am still working on the Mod 3 vignettes, however the R document contains a detailed explanation of what the two functions' goals are, and can be reviewed in the meantime while I continue to work on the Mod 3 vignettes.