-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update angular version to 15 and Keycloak to 13 #242
base: master
Are you sure you want to change the base?
Conversation
We decided to stop at Angular version 15 instead of the current latest version of 16 due to certain dependencies that did not work with Angular version 16 at the time of writing:
|
…owever not sure whether this theme is actually used within the application. For further information see: https://material.angular.io/guide/theming
…ion of the existing theme to the new style. For further information see: https://material.angular.io/guide/theming
…-atlas-ui into update-angular-16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bildschirmaufnahme.2023-10-25.um.15.56.40.mov
changing to other entities the page is not loading, see video. Note: navigation via menu on the right side works as usual
Getting error: ERROR Error: Uncaught (in promise): TypeError: e[a] is not a function
|
The .webpack dir and sourcemaps in general can be brought back by adding From what I could tell from debugging, the error from the video is related to cleaning up the ripple effect of some buttons (e.g. the save button in the app-text-input for algorithm parameters and some add button(s)? that I have not investigated yet). This is likely because of some library update that causes problems (either because the library is incompatible with something or because we did not perform a required change in our code). I am not sure if that is the root cause for the navigation issue though. Edit 31.10.: It is indeed the buttons that cause these problems. More specifically material icon buttons. Removing them from the page (or removing the |
@@ -14,7 +14,7 @@ jobs: | |||
- name: Set up Node.js | |||
uses: actions/setup-node@v1 | |||
with: | |||
node-version: 12 | |||
node-version: 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test if this also works with node 18 and use 18 if possible (or even 20). Node version 16 is an lts version but is no longer maintained.
description: dialogResult.description, | ||
}; | ||
const updatedComputeResourcePropertyType: ComputeResourcePropertyTypeDto = | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the usual style of brackets in the javascript/typescript world. This probably is related to the commented bracket rule in the linter config. If this is changed, then multiple other places that are also affected need to be changed as well.
@@ -8,11 +8,12 @@ | |||
|
|||
} | |||
|
|||
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
::ng-deep .mat-form-field-appearance-fill .mdc-text-field {
background-color: transparent;
}
[matAutosizeMaxRows]="3" | ||
[matAutosizeMinRows]="2" | ||
[matTextareaAutosize]="true" | ||
cdkAutosizeMaxRows="3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a maximum of 3 rows seems a little too small for larger latex content this is intended for. Also the dialog renders way too thin...
About the dependencies blocking angular 16:
Edit 31.10.: angular-bootstrap-md has a direct successor that is compatible with angular 16: https://www.npmjs.com/package/mdb-angular-ui-kit The catch is that this uses a new Bootstrap version, so it may still be better/easier to remove the dependency entirely, as all styling issues would have to be checked either way. I have tested removing the dependency locally by force and it did not take too long to get it to compile again. But there were some style issues that would need fixing. |
This PR updates the Angular Version to 15 and the Angular Keycloak version to 13.