Feature/plugin filter editor #48

infacc · 2023-07-11T08:15:27Z

No description provided.

src/app/components-small/template-details/template-details.component.ts

src/app/components-small/template-details/template-details.component.html

src/app/components-small/plugin-filter-node/plugin-filter-node.component.ts

buehlefs · 2023-07-11T13:55:41Z

src/app/components-small/plugin-filter-node/plugin-filter-node.component.html

@@ -0,0 +1,71 @@
+<div>
+    <div *ngIf="isFilterEmpty()" class="create-buttons">


This should be handled in the parent component (a node cannot create or delete itself normally...)

This is meant for empty filters ({}). I.e. when a tab is newly created. The HTML class name create-buttons is misleading, I changed it to set-buttons.

src/app/components-small/plugin-filter-node/plugin-filter-node.component.html

src/app/components-small/plugin-filter-editor/plugin-filter-editor.component.ts

Co-authored-by: Fabian Bühler <fabian.buehler@iaas.uni-stuttgart.de>

…/qhana-ui into feature/plugin-filter-editor

src/app/components-small/plugin-filter-node/plugin-filter-node.component.ts

src/app/components-small/template-details/template-details.component.html

child components should not know their index in a list of their parent

src/app/components-small/plugin-filter-node/plugin-filter-node.component.ts

buehlefs

Looks good, but there is another bug with the tab editing form. The form does not contain the name or description of an existing tab (the sort key may have the same problem)

the filter string is a separate property and handled by the PluginFilterEditorComponent

infacc · 2023-07-20T12:40:35Z

The form didn't display the tab name/description/sortKey since I forgot to remove the filterString from the FormGroup. Now it works.

buehlefs

I think this should be ready for merging then.

infacc · 2023-07-20T21:01:48Z

I added 2 more things:

A reload button for the filter editor, which resets the filter editor to the saved filter.
A JSON validator for the JSON editor (of the filter string). This doesn't validate the filter string but complains if the user enters invalid JSON.

buehlefs

Just one cosmetic/formulation change

src/app/components-small/plugin-filter-editor/plugin-filter-editor.component.html

Co-authored-by: Fabian Bühler <fabian.buehler@iaas.uni-stuttgart.de>

infacc added 4 commits July 1, 2023 17:59

add plugin filter editor

01bf1bb

show plugin editor when no tab link is provided

e55a407

hide mat-card if filter is empty

8b1fe43

refactor: improve filter editor usability

5616886

infacc requested a review from buehlefs July 11, 2023 08:15

buehlefs reviewed Jul 11, 2023

View reviewed changes

infacc and others added 9 commits July 12, 2023 13:46

refactor: avoid ViewChild decorator in filter editor

76d7744

simplify isLeaf check

4e2edb3

rectify warning message

38879c2

Co-authored-by: Fabian Bühler <fabian.buehler@iaas.uni-stuttgart.de>

refactor: simplify filter setup

e71700b

Merge branch 'feature/plugin-filter-editor' of github.com:UST-QuAntiL…

d81143a

…/qhana-ui into feature/plugin-filter-editor

handle filter deletion by parent

fae56c0

catch JSON paring errors

4ceb6d4

separate ternary operator to improve readability

183ced2

add inverted indication for and/or filters

a1fe552

buehlefs reviewed Jul 14, 2023

View reviewed changes

infacc added 11 commits July 17, 2023 13:19

remove index property

05d026b

child components should not know their index in a list of their parent

store info whether filter is empty in property

f62ff31

refactor: separate input and output objects

334189a

check for empty filter

c0ee392

fix bug: keep input focus when typing

51171f8

fix bug: use JSON editor input on tab change

fff9496

add active warning for filters with multiple attributes

be07ea4

set filter string via template expression

9622400

refactor: simplify type check for filter keys

ec041cf

Merge branch 'main' into feature/plugin-filter-editor

62344c6

rename HTML class to avoid confusion

b8b6cf6

buehlefs reviewed Jul 19, 2023

View reviewed changes

src/app/components-small/plugin-filter-node/plugin-filter-node.component.ts Outdated Show resolved Hide resolved

src/app/components-small/plugin-filter-node/plugin-filter-node.component.ts Outdated Show resolved Hide resolved

use deep copies to emit filters

16dd6a5

buehlefs reviewed Jul 20, 2023

View reviewed changes

remove filter string from template form

8ea5eea

the filter string is a separate property and handled by the PluginFilterEditorComponent

buehlefs approved these changes Jul 20, 2023

View reviewed changes

infacc added 3 commits July 20, 2023 22:36

add reload filter button

af7ad6b

remove unused location interface

37526f4

add JSON validator to filter string textarea input

6a33202

buehlefs requested changes Jul 21, 2023

View reviewed changes

src/app/components-small/plugin-filter-editor/plugin-filter-editor.component.html Outdated Show resolved Hide resolved

src/app/components-small/plugin-filter-editor/plugin-filter-editor.component.html Outdated Show resolved Hide resolved

infacc and others added 2 commits July 21, 2023 13:38

rename revert filter button

f5423d5

Co-authored-by: Fabian Bühler <fabian.buehler@iaas.uni-stuttgart.de>

hide button from screen readers

eb4ebca

infacc requested a review from buehlefs July 21, 2023 11:50

buehlefs approved these changes Jul 21, 2023

View reviewed changes

infacc merged commit 647d08a into main Jul 21, 2023
2 checks passed

infacc deleted the feature/plugin-filter-editor branch July 21, 2023 12:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/plugin filter editor #48

Feature/plugin filter editor #48

infacc commented Jul 11, 2023

buehlefs Jul 11, 2023

infacc Jul 18, 2023

buehlefs left a comment

infacc commented Jul 20, 2023

buehlefs left a comment

infacc commented Jul 20, 2023

buehlefs left a comment

		@@ -0,0 +1,71 @@
		<div>
		<div *ngIf="isFilterEmpty()" class="create-buttons">

Feature/plugin filter editor #48

Feature/plugin filter editor #48

Conversation

infacc commented Jul 11, 2023

buehlefs Jul 11, 2023

Choose a reason for hiding this comment

infacc Jul 18, 2023

Choose a reason for hiding this comment

buehlefs left a comment

Choose a reason for hiding this comment

infacc commented Jul 20, 2023

buehlefs left a comment

Choose a reason for hiding this comment

infacc commented Jul 20, 2023

buehlefs left a comment

Choose a reason for hiding this comment