Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/plugin filter editor #48
Feature/plugin filter editor #48
Changes from 4 commits
01bf1bb
e55a407
8b1fe43
5616886
76d7744
4e2edb3
38879c2
e71700b
d81143a
fae56c0
4ceb6d4
183ced2
a1fe552
05d026b
f62ff31
334189a
c0ee392
51171f8
fff9496
be07ea4
9622400
ec041cf
62344c6
b8b6cf6
16dd6a5
8ea5eea
af7ad6b
37526f4
6a33202
f5423d5
eb4ebca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be handled in the parent component (a node cannot create or delete itself normally...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is meant for empty filters (
{}
). I.e. when a tab is newly created. The HTML class namecreate-buttons
is misleading, I changed it toset-buttons
.