Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shader name Standard (Roughness Setup) should be Autodesk Interactive in StandardsToHDLitMaterialUpgrader #7829

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −1
Open

Shader name Standard (Roughness Setup) should be Autodesk Interactive in StandardsToHDLitMaterialUpgrader #7829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba61fe3
Update CHANGELOG.md
eliphatfs Feb 21, 2023
dd5c552
Shader name to `Autodesk Interactive` in upgrader.
eliphatfs Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Packages/com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this package will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Fixed
- Fixed upgrading materials from Autodesk Interative shaders.


## [16.0.0] - 2023-01-18

Expand Down
2 changes: 1 addition & 1 deletion ...unity.render-pipelines.high-definition/Editor/Upgraders/UpgradeStandardShaderMaterials.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ static List<MaterialUpgrader> GetHDUpgraders()
var upgraders = new List<MaterialUpgrader>();
upgraders.Add(new StandardsToHDLitMaterialUpgrader("Standard", "HDRP/Lit"));
upgraders.Add(new StandardsToHDLitMaterialUpgrader("Standard (Specular setup)", "HDRP/Lit"));
upgraders.Add(new StandardsToHDLitMaterialUpgrader("Standard (Roughness setup)", "HDRP/Lit"));
upgraders.Add(new StandardsToHDLitMaterialUpgrader("Autodesk Interactive", "HDRP/Lit"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RemyUnity could you confirm this? And also I think we need to update Standard (Specular setup)


upgraders.Add(new UnlitsToHDUnlitUpgrader("Unlit/Color", "HDRP/Unlit"));
upgraders.Add(new UnlitsToHDUnlitUpgrader("Unlit/Texture", "HDRP/Unlit"));
Expand Down