ABT-3931: Always include imp.instl and disentangle regs.gdpr NO/UNKNOWN values
#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curly-brace-butler
changed the title
imp.instl and disentangle regs.gdpr NO/UNKNOWN values
junwu-unity
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imp.instlno longer omitted during JSON-encode of bid requests. The field deserializes identically, but serializes with more human-readability at the cost of a small space increase.regs.gdprchanged to nil-able pointer representation. The field serializes identically, but deserializes differently in the case whereregs.gdpris omitted. In the omission case, unmarshals to nil instead of zero which allows the third value "UNKNOWN" described in the ORTB2.X spec to be represented.