Skip to content

ABT-3931: Always include imp.instl and disentangle regs.gdpr NO/UNKNOWN values #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
curly-brace-butler merged 5 commits into from
Nov 19, 2025
Merged

ABT-3931: Always include imp.instl and disentangle regs.gdpr NO/UNKNOWN values #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e1346ac
[#PPS-3931]
curly-brace-butler Nov 17, 2025
aa91c41
[#ABT-3931] Remove omitempty from ambiguous regs.gdpr, imp.instl (kin…
curly-brace-butler Nov 18, 2025
0b0d95d
[#PPS-3931] possible instl explicit 0
curly-brace-butler Nov 18, 2025
40a9cf6
[#PPS-3931] regs gdpr nilability, instl test
curly-brace-butler Nov 18, 2025
af22db4
[#PPS-3931] test only covers decode. encode behavior was changed
curly-brace-butler Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion impression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type Impression struct {
DisplayManager string `json:"displaymanager,omitempty"` // Name of ad mediation partner, SDK technology, etc
DisplayManagerVer string `json:"displaymanagerver,omitempty"` // Version of the above
Clickbrowser int `json:"clickbrowser"` // Indicates the type of browser opened upon clicking the creative in an app, where 0 = embedded, 1 = native
Instl int `json:"instl,omitempty"` // Interstitial, Default: 0 ("1": Interstitial, "0": Something else)
Instl int `json:"instl"` // Interstitial, Default: 0 ("1": Interstitial, "0": Something else)
TagID string `json:"tagid,omitempty"` // IDentifier for specific ad placement or ad tag
BidFloor float64 `json:"bidfloor,omitempty"` // Bid floor for this impression in CPM
BidFloorCurrency string `json:"bidfloorcur,omitempty"` // Currency of bid floor
Expand Down
2 changes: 1 addition & 1 deletion openrtb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,7 @@ type UID struct {
// regulations for the United States Children's Online Privacy Protection Act ("COPPA").
type Regulations struct {
Coppa int `json:"coppa,omitempty"` // Flag indicating if this request is subject to the COPPA regulations established by the USA FTC, where 0 = no, 1 = yes.
GDPR int `json:"gdpr,omitempty"` // Flag that indicates whether or not the request is subject to GDPR regulations 0 = No, 1 = Yes, omission indicates Unknown.
GDPR *int `json:"gdpr,omitempty"` // Flag that indicates whether the request is subject to GDPR regulations 0 = No, 1 = Yes, omission indicates Unknown.
USPrivacy string `json:"us_privacy,omitempty"` // Communicates signals regarding consumer privacy under US privacy regulation.
Ext RegExtension `json:"ext,omitempty"`
}
Expand Down
Loading