Remove quality criteria promise statements from step instructions#213
Merged
Remove quality criteria promise statements from step instructions#213
Conversation
…nstructions This self-attestation pattern was an old way for agents to declare they met quality criteria. It has been fully superseded by the QualityGate system which uses structured evaluation via Claude CLI subprocess or self-review subagent. The <promise> tag in step instructions served no purpose and was not consumed by any code. https://claude.ai/code/session_01SbfdKun53EC4je7CgvnmuB
…repair workflow The fix_jobs step now includes Step 8 to find and remove the old self-attestation <promise> lines from step instruction .md files. Also updates the sub-agent prompt checklist and adds a review criterion. https://claude.ai/code/session_01SbfdKun53EC4je7CgvnmuB
nhorton
force-pushed
the
claude/remove-deprecated-criteria-GZ7g5
branch
from
b8de40f to
9829b38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
<promise>Quality Criteria Met</promise>statements from step instruction templates and job definitions. These promise tags were included at the end of quality criteria sections but are being removed as part of a cleanup effort.Changes Made
create_test_review_job.mdquality criteria sectionidentify_improvements.mdquality criteria sectionreview_creation_process.mdquality criteria sectionstep_instruction.md.exampletemplatestep_instruction.md.templatetemplateDetails
The
<promise>Quality Criteria Met</promise>(and variant<promise>✓ Quality Criteria Met</promise>) statements were consistently placed at the end of the "Quality Criteria" sections across multiple step instruction files. These have been removed to streamline the instruction format and reduce redundancy in the step definition templates.https://claude.ai/code/session_01SbfdKun53EC4je7CgvnmuB