Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/deepwork/standard_jobs/deepwork_jobs/job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ steps:
"Stop Hooks Migrated": "Are `stop_hooks` migrated to `hooks.after_agent` format?"
"Removed Steps Cleaned": "Are references to removed steps (like `review_job_spec`) updated?"
"Orphaned Steps Fixed": "For jobs with no workflows, is there a single workflow (named after the job) containing all steps? For jobs with existing workflows, does each orphan get its own workflow (named after the step)?"
"Promise Lines Removed": "Are deprecated `<promise>Quality Criteria Met</promise>` lines removed from step instruction .md files?"
"Valid YAML": "Are all job.yml files valid YAML?"

- id: errata
Expand Down
23 changes: 20 additions & 3 deletions src/deepwork/standard_jobs/deepwork_jobs/steps/fix_jobs.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,9 @@ Then audit and repair the job at `.deepwork/jobs/[job_name]/job.yml`:
9. Replace `description:` with `common_job_info_provided_to_all_steps_at_runtime:` if present
10. Remove any info in `common_job_info_provided_to_all_steps_at_runtime` that is not relevant to most steps.
11. Read the step instructions and remove anything that is repeated in many steps and put it into `common_job_info_provided_to_all_steps_at_runtime`
12. Bump version if changes were made
13. Validate YAML syntax
12. Remove `<promise>Quality Criteria Met</promise>` lines from step instruction .md files
13. Bump version if changes were made
14. Validate YAML syntax

Report only: which checks passed with no changes, and which changes were made (one line each).
```
Expand Down Expand Up @@ -252,7 +253,22 @@ steps:
3. **For steps with no quality_criteria**: Use `reviews: []`
4. **Remove the old field**: Delete the `quality_criteria` array entirely after migration.

### Step 8: Update Version Numbers
### Step 8: Remove Deprecated `<promise>Quality Criteria Met</promise>` from Step Instructions

Old step instruction templates included a line telling the agent to self-attest quality by emitting a `<promise>` tag. This has been fully replaced by the structured `reviews` system with `QualityGate` evaluation. The old line serves no purpose and should be removed.

**Find and remove lines like these from step instruction `.md` files:**

```markdown
- When all criteria are met, include `<promise>✓ Quality Criteria Met</promise>` in your response
- When all criteria are met, include `<promise>Quality Criteria Met</promise>` in your response
```

**Where to look:** Check every `.md` file in each job's `steps/` directory. The line typically appears as the last bullet in a `## Quality Criteria` section.

**What to do:** Delete the line entirely. Do not replace it with anything — the `reviews` system in `job.yml` now handles quality evaluation.

### Step 9: Update Version Numbers

If you made significant changes to a job, bump its version number:

Expand Down Expand Up @@ -299,6 +315,7 @@ For each job in `.deepwork/jobs/`, check:
| `stop_hooks` | Migrate to `hooks.after_agent` |
| `outputs` format | Migrate from array to map with `type` and `description` |
| `quality_criteria` | Migrate to `reviews` with `run_each` and map-format criteria |
| `<promise>` in step `.md` files | Remove deprecated `Quality Criteria Met` self-attestation lines |
| Workflow steps | Remove references to deleted steps |
| Dependencies | Update to valid step IDs |
| File inputs | Update `from_step` references; update keys for renamed outputs |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ A markdown document listing each competitor with context.
- Each competitor has clear, specific description
- Selection rationale explains the competitive landscape
- Output is well-formatted and ready for use by next step
- When all criteria are met, include `<promise>✓ Quality Criteria Met</promise>` in your response

## Context

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
- [Quality criterion 1]
- [Quality criterion 2]
- [Quality criterion 3]
- When all criteria are met, include `<promise>✓ Quality Criteria Met</promise>` in your response

## Context

Expand Down