Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robustness to part download failures due to 403 errors #5

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

apockill
Copy link
Member

It seems like some parts just consistently fail to download due to access rights errors. I think this leads to a loop where andrew or gabby have to

  1. run exporter
  2. see a 403 failure on part X
  3. go on onshape and "suppress" part X
  4. go back to step 1

So this helps remove that loop, and speeds up the process! Root cause for 403 errors is unknown though :/

@apockill apockill requested a review from velovix March 14, 2024 17:06
@velovix
Copy link
Member

velovix commented Mar 25, 2024

Is this an error that Gabby and Andrew are seeing or is it something software folks are seeing? I've gotten 403 errors in the past because I was shared on only part of an assembly (or something like that) and Andrew was able to fix it for my by sharing me on more of it. If it's something hardware folks are seeing, that's a mysterious issue to me and I would be down with merging this.

@apockill
Copy link
Member Author

Is this an error that Gabby and Andrew are seeing or is it something software folks are seeing? I've gotten 403 errors in the past because I was shared on only part of an assembly (or something like that) and Andrew was able to fix it for my by sharing me on more of it. If it's something hardware folks are seeing, that's a mysterious issue to me and I would be down with merging this.

That's good to know! In this case, this was something gabby was seeing, and only on certain parts of the export.

@apockill apockill merged commit f87247b into main Mar 25, 2024
1 check passed
@apockill apockill deleted the feature/robust-to-part-download-failures branch March 25, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants