Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC 14.37の仕様変更への対応 #11

Merged
merged 2 commits into from
Sep 7, 2023
Merged

MSVC 14.37の仕様変更への対応 #11

merged 2 commits into from
Sep 7, 2023

Conversation

My-MC
Copy link

@My-MC My-MC commented Sep 3, 2023 •
edited
Loading

内容

#10 の解決を行います。

こちらがマージされましたら、pyopenjtalkの方にもコミットIDの変更のPR、のちにvoicevox_engineにもPRを出します。

関連 Issue

Resolve #10

スクリーンショット・動画など

その他

y-chan
y-chan reviewed Sep 3, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おおよそLGTMですが、コメントさせていただきました...!

src/mecab/src/dictionary.cpp Show resolved Hide resolved
@Hiroshiba
Copy link
Member

Hiroshiba commented Sep 7, 2023 •
edited
Loading

プルリクエスト＆検証ありがとうございます！！問題ないと思うのでマージします！
VOICEVOX/pyopenjtalkも更新しちゃいたいですね･･･！！

@Hiroshiba Hiroshiba merged commit 78e1829 into VOICEVOX:1.11 Sep 7, 2023
5 checks passed
This was referenced Sep 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba left review comments

@y-chan y-chan y-chan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSVC 14.37の仕様変更への対応
3 participants
@My-MC @Hiroshiba @y-chan