Fix: Broken DashScope support introduced in PR 441 (previous integration was non‑native and unusable)#450
Closed
byronwang2005 wants to merge 5 commits intoValueCell-ai:mainfrom
Closed
Conversation
…ontend settings page—now displayed only for non-DashScope providers
Collaborator
|
link: #441 |
Contributor
|
Please review this PR: #451. I resolved this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Template
1. Related Issue
Fixes the broken DashScope support introduced in PR “Feat/support dashscope” (previous integration was non‑native and unusable).
2. Type of Change (select one)
Type of Change: Bug Fix
3. Description
python/valuecell/adapters/models/factory.py:655-656python/valuecell/utils/model.py:60-63base_url)frontend/src/app/setting/components/models/model-detail.tsx:219-235python/configs/providers/dashscope.yaml:1-83python/valuecell/adapters/models/factory.py:684python/valuecell/adapters/models/factory.py:591-5934. Testing
5. Checklist