Skip to content

Conversation

@hazeone
Copy link
Contributor

@hazeone hazeone commented Nov 27, 2025

📝 Pull Request Template

1. Related Issue

2. Type of Change (select one)

Type of Change: Bug Fix

3. Description

Resolve minor chore problems in PR #441

4. Testing

  • I have tested this locally.
  • I have updated or added relevant tests.

5. Checklist

@hazeone hazeone requested a review from vcfgv November 27, 2025 09:40
@hazeone
Copy link
Contributor Author

hazeone commented Nov 27, 2025

@byronwang2005 You can review this PR; it doesn't require significant changes.

@byronwang2005
Copy link
Contributor

Yes, it was originally just a minor glitch—but I just realized this calling method still isn’t native DashScope; it’s still OpenAI-compatible.

@vcfgv vcfgv changed the title fix(model): fix DashScope provider error fix(model): DashScope provider error Nov 27, 2025
@hazeone hazeone merged commit fd18e39 into main Nov 27, 2025
3 checks passed
@hazeone hazeone deleted the fix/dashscrope_provider_error branch November 27, 2025 09:46
@byronwang2005
Copy link
Contributor

But even this modification isn’t truly native—see link: DashScope doesn’t require a base_url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants