Add32 proofs in new formulation #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
changed the title
marcobesier
approved these changes
Jan 14, 2025
Clean/Types/U32.lean
Outdated
| @@ -44,6 +47,12 @@ def is_normalized (x: U32 (F p)) := | |||
| def value (x: U32 (F p)) := | |||
| x.x0.val + x.x1.val * 256 + x.x2.val * 256^2 + x.x3.val * 256^3 | |||
|
|
|||
| /-- | |||
| Return the value of a 32-bit unsigned integer as a field | |||
There was a problem hiding this comment.
There is a missing word in this comment:
Return the value of a 32-bit unsigned integer as a field **element.**
Admittedly, it is a non-issue, but we might still want to fix it for the sake of clarity.
There was a problem hiding this comment.
ah, yep I'm actually used to just saying "field" instead of "field element", because this was the widely used shorthand in the ecosystem I worked in (Mina / o1js).
(in Starkware/Cairo they say "felt" :D)
There was a problem hiding this comment.
ah, got it! felt is next level, tho 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6
field_to_nat_u32