Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trusted scoring signals related steps. #685

Merged
merged 10 commits into from
Jul 18, 2023
Merged

Fix trusted scoring signals related steps. #685

merged 10 commits into from
Jul 18, 2023

Conversation

qingxinwu
Copy link
Collaborator

@qingxinwu qingxinwu commented Jun 29, 2023 •
edited by pr-preview bot
Loading

For trusted scoring signals fetch:

  1. In score and rank a bid, changed |renderURLs| to |renderURL| since we're not batching the fetches from multiple scoreAd() (we asserted that |renderURLs|'s size was 1). Also reword related steps.
  2. In [=fetch trusted signals=], serialize values of the signals map, and it can be converted to a JS value using WebIDL convert algorithm since it (map<string, string>) can be treated as a record.

Preview | Diff

@qingxinwu
Copy link
Collaborator Author

@domfarolino PTAL. I know all the converting steps from IDL to js can be thrown away when the issue "Use WebIDL callback invocation" is done, since that can automatically do the conversion, but I'm keeping the manual conversion of the arguments for now.

@qingxinwu qingxinwu added the spec Relates to the spec label Jun 29, 2023
domfarolino
domfarolino reviewed Jul 7, 2023
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
domfarolino
domfarolino reviewed Jul 12, 2023
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@domfarolino domfarolino reopened this Jul 18, 2023
@domfarolino
Copy link
Collaborator

(Re-opening to kick-off the PR preview bot again; it seems stuck)

domfarolino
domfarolino reviewed Jul 18, 2023
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
domfarolino
domfarolino approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingxinwu qingxinwu merged commit f25bcc6 into WICG:main Jul 18, 2023
2 checks passed
@qingxinwu qingxinwu deleted the renderurl branch July 18, 2023 18:12
github-actions bot added a commit that referenced this pull request Jul 18, 2023
@qingxinwu @github-actions
Fix trusted scoring signals related steps. (#685)
3863c6b 
SHA: f25bcc6
Reason: push, by qingxinwu

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to qingxinwu/turtledove that referenced this pull request Jul 18, 2023
@qingxinwu @github-actions
Fix trusted scoring signals related steps. (WICG#685)
44ac791 
SHA: f25bcc6
Reason: push, by qingxinwu

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to brusshamilton/turtledove that referenced this pull request Jul 18, 2023
@qingxinwu @github-actions
Fix trusted scoring signals related steps. (WICG#685)
4719a80 
SHA: f25bcc6
Reason: push, by brusshamilton

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domfarolino domfarolino domfarolino approved these changes

Assignees
No one assigned
Labels
spec Relates to the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingxinwu @domfarolino