Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trusted scoring signals related steps. #685

Merged
merged 10 commits into from
Jul 18, 2023
Merged

Fix trusted scoring signals related steps. #685

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5ced526
Fix trusted scoring signals related steps.
Jun 29, 2023
931c03b
convert |auctionConfigIDL| to js value.
Jun 29, 2023
f3ef49a
Merge branch 'WICG:main' into renderurl
qingxinwu Jun 29, 2023
d336fab
Merge branch 'WICG:main' into renderurl
qingxinwu Jul 7, 2023
36884f2
Merge branch 'WICG:main' into renderurl
qingxinwu Jul 7, 2023
3c621d2
Merge branch 'WICG:main' into renderurl
qingxinwu Jul 11, 2023
d0943ad
Merge branch 'WICG:main' into renderurl
qingxinwu Jul 13, 2023
893ace6
Change trusted signals map values to serialized.
Jul 14, 2023
a3fb705
serialization always return a string.
Jul 18, 2023
e6bffe4
Merge branch 'WICG:main' into renderurl
qingxinwu Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 50 additions & 43 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ spec: html; urlPrefix: https://html.spec.whatwg.org/C
text: create an agent; url: create-an-agent
text: immediately; url: immediately
text: valid floating-point number; url: valid-floating-point-number
spec: infra; urlPrefix: https://infra.spec.whatwg.org/
type: dfn
text: convert an Infra value to a JSON-compatible JavaScript value; url: #convert-an-infra-value-to-a-json-compatible-javascript-value
spec: RFC8941; urlPrefix: https://httpwg.org/specs/rfc8941.html
type: dfn
text: structured header; url: top
Expand Down Expand Up @@ -1361,41 +1364,40 @@ To <dfn>score and rank a bid</dfn> given an [=auction config=] |auctionConfig|,
"single-level-auction", "top-level-auction", or "component-auction", a [=currency tag=]
|componentAuctionExpectedCurrency|, and an [=origin=] |topWindowOrigin|:

1. Let |renderURLs| be a new [=set=].
1. Let |adComponentRenderUrls| be a new [=set=].
1. [=set/Append=] |generatedBid|'s [=generated bid/ad descriptor=]'s [=ad descriptor/url=] to |renderURLs|.
1. Let |renderURL| be [=URL serializer|serialized=] |generatedBid|'s
[=generated bid/ad descriptor=]'s [=ad descriptor/url=].
1. Let |adComponentRenderURLs| be a new empty [=list=].
1. If |generatedBid|'s [=generated bid/ad component descriptors=] is not null:
1. [=set/For each=] |adComponentDescriptor| in |generatedBid|'s
1. [=list/For each=] |adComponentDescriptor| in |generatedBid|'s
[=generated bid/ad component descriptors=]:
1. [=set/Append=] |adComponentDescriptor|'s [=ad descriptor/url=] to |adComponentRenderUrls|.
1. [=list/Append=] [=URL serializer|serialized=] |adComponentDescriptor|'s [=ad descriptor/url=]
to |adComponentRenderURLs|.
1. Let |fullSignalsUrl| be the result of [=building trusted scoring signals url=] with |auctionConfig|'s
[=auction config/trusted scoring signals url=], |renderURLs|, |adComponentRenderUrls|,
[=auction config/trusted scoring signals url=], «|renderURL|», |adComponentRenderURLs|,
|auctionConfig|'s [=auction config/seller experiment group id=], and |topWindowOrigin|.

Implementations may batch requests by collecting render URLs and ad component render URLs
from multiple invocations of [=score and rank a bid=] and passing them all to a single invocation
of [=building trusted scoring signals url=] -- the network response has to be parsed to pull out the pieces
relevant to each [=evaluating a scoring script|evaluation of a scoring script=].
of [=building trusted scoring signals url=] -- the network response has to be parsed to pull out
the pieces relevant to each [=evaluating a scoring script|evaluation of a scoring script=].
1. Let |trustedScoringSignals| be null.
1. Let «|allTrustedScoringSignals|, |scoringDataVersion|» be the result of [=fetching trusted signals=] with
|fullSignalsUrl| and false.
1. Let «|allTrustedScoringSignals|, |scoringDataVersion|» be the result of [=fetching trusted signals=]
with |fullSignalsUrl| and false.
1. If |allTrustedScoringSignals| is an [=ordered map=]:
1. Let |trustedScoringSignals| be a new [=map=].
1. [=Assert=]: |renderURLs|'s [=set/size=] is 1.
1. [=set/For each=] |renderURL| in |renderURLs|:
1. If |allTrustedScoringSignals|["`renderURLs`"] [=map/exists=] and
|allTrustedScoringSignals|["`renderURLs`"][|renderURL|] [=map/exists=]:
1. Let |renderURLValue| be a new [=map=].
1. [=map/Set=] |renderURLValue|[|renderURL|] to |allTrustedScoringSignals|["`renderURLs`"][|renderURL|].
1. [=map/Set=] |trustedScoringSignals|["`renderURL`"] to |renderURLValue|.
1. Let |adComponentRenderUrlsValue| be a new [=map=].
1. [=set/For each=] |adComponentRenderUrl| in |adComponentRenderUrls|:
1. If |allTrustedScoringSignals|["`adComponentRenderUrls`"] [=map/exists=] and
|allTrustedScoringSignals|["`adComponentRenderUrls`"][|adComponentRenderUrl|] [=map/exists=]:
1. [=map/Set=] |adComponentRenderUrlsValue|[|adComponentRenderUrl|] to
|allTrustedScoringSignals|["`adComponentRenderUrls`"][|adComponentRenderUrl|].
1. If |adComponentRenderUrlsValue| is not [=map/is empty|empty=]:
1. [=map/Set=] |trustedScoringSignals|["`adComponentRenderUrls`"] to |adComponentRenderUrlsValue|.
1. Set |trustedScoringSignals| to a new empty [=map=].
1. [=map/Set=] |trustedScoringSignals|["`renderURL`"] to a new empty [=map=].
1. If |allTrustedScoringSignals|["`renderURLs`"] [=map/exists=] and
|allTrustedScoringSignals|["`renderURLs`"][|renderURL|] [=map/exists=]:
1. [=map/Set=] |trustedScoringSignals|["`renderURL`"][|renderURL|] to
|allTrustedScoringSignals|["`renderURLs`"][|renderURL|].
1. If |adComponentRenderURLs| is not [=list/empty=]:
1. Let |adComponentRenderURLsValue| be a new empty [=map=].
1. If |allTrustedScoringSignals|["`adComponentRenderURLs`"] [=map/exists=], [=set/for each=]
|adComponentRenderURL| in |adComponentRenderURLs|:
1. If |allTrustedScoringSignals|["`adComponentRenderURLs`"][|adComponentRenderURL|] [=map/exists=]:
1. [=map/Set=] |adComponentRenderURLsValue|[|adComponentRenderURL|] to
|allTrustedScoringSignals|["`adComponentRenderURLs`"][|adComponentRenderURL|].
1. [=map/Set=] |trustedScoringSignals|["`adComponentRenderURLs`"] to |adComponentRenderURLsValue|.
1. Let |adMetadata| be |generatedBid|'s [=generated bid/ad=].
1. Let |bidValue| be |generatedBid|'s [=generated bid/bid=].
1. If |generatedBid|'s [=generated bid/modified bid=] is not null:
Expand Down Expand Up @@ -1700,29 +1702,24 @@ To <dfn>build trusted bidding signals url</dfn> given a [=URL=] |signalsUrl|, an

<div algorithm>

To <dfn>build trusted scoring signals url</dfn> given a [=URL=] |signalsUrl|, an [=ordered set=] of
[=URLs=] |renderURLs|, an [=ordered set=] of [=URLs=] |adComponentRenderUrls|, an {{unsigned short}}
|experimentGroupId|, and an [=origin=] |topWindowOrigin|:
To <dfn>build trusted scoring signals url</dfn> given a [=URL=] |signalsUrl|, a [=list=] of
[=strings=] |renderURLs|, an [=ordered set=] of [=strings=] |adComponentRenderURLs|, an
{{unsigned short}} |experimentGroupId|, and an [=origin=] |topWindowOrigin|:

Note: When trusted scoring signals fetches are not batched, |renderURLs|'s [=list/size=] is 1.

1. Let |queryParamsList| be a new empty [=list=].
1. [=list/Append=] "hostname=" to |queryParamsList|.
1. [=list/Append=] the result of [=string/UTF-8 percent-encoding=] |topWindowOrigin| using
[=component percent-encode set=] to |queryParamsList|.
1. If |renderURLs| is not [=set/is empty|empty=]:
1. [=list/Append=] "&renderURLs=" to |queryParamsList|.
1. Let |renderURLsStrings| be a new empty [=list=].
1. [=list/For each=] |renderURL| of |renderURLs|:
1. [=list/Append=] the result of [=URL serializer|serialization=] of |renderURL| to
|renderURLsStrings|.
1. [=list/Extend=] |queryParamsList| with the result of [=encode trusted signals keys=] with
|renderURLsStrings|.
1. If |adComponentRenderUrls| is not [=set/is empty|empty=]:
1. [=list/Append=] "&adComponentRenderUrls=" to |queryParamsList|.
1. Let |adComponentRenderUrlsStrings| be a new empty [=list=].
1. [=list/For each=] |adComponentRenderUrl| of |adComponentRenderUrls|:
1. [=list/Append=] the result of [=URL serializer|serialization=] of |adComponentRenderUrl| to
|adComponentRenderUrlsStrings|.
|renderURLs|.
1. If |adComponentRenderURLs| is not [=set/is empty|empty=]:
1. [=list/Append=] "&adComponentRenderURLs=" to |queryParamsList|.
1. [=list/Extend=] |queryParamsList| with the result of [=encode trusted signals keys=] with
|adComponentRenderUrlsStrings|.
|adComponentRenderURLs|.
1. If |experimentGroupId| is not null:
1. [=list/Append=] "&experimentGroupId=" to |queryParamsList|.
1. [=list/Append=] [=serialize an integer|serialized=] |experimentGroupId| to |queryParamsList|.
Expand Down Expand Up @@ -2198,9 +2195,19 @@ of the following global objects:
1. Let |realm| be the result of [=creating a new script runner realm=] given
{{InterestGroupScoringScriptRunnerGlobalScope}}.
1. Let |browserSignalsJS| be |browserSignals| [=converted to ECMAScript values=].
1. TODO: convert |trustedScoringSignals| to a JS value.
1. Let |convertedTrustedScoringSignals| be a new empty [=map].
qingxinwu marked this conversation as resolved.
Show resolved Hide resolved
1. [=map/For each=] |key| -> |value| of |trustedScoringSignals|:
1. Let |valueString| be the result of [=serializing an Infra value to a JSON string=] given
|value|.
1. If the previous steps did not [=exception/throw=] an exception:
domfarolino marked this conversation as resolved.
Show resolved Hide resolved
1. [=map/Set=] |convertedTrustedScoringSignals||key| to |valueString|.
1. Let |auctionConfigJS| be the result of [=converted to ECMAScript values|converting=]
|auctionConfigIDL| to an ECMAScript value.
1. Let |trustedScoringSignalsJS| be the result of
domfarolino marked this conversation as resolved.
Show resolved Hide resolved
[=converting an Infra value to a JSON-compatible JavaScript value=] given
|convertedTrustedScoringSignals|.
1. Return the result of [=evaluating a script=] with |realm|, |script|, "`scoreAd`",
«|adMetadata|, |bidValue|, |auctionConfigIDL|, |trustedScoringSignals|, |browserSignalsJS|»,
«|adMetadata|, |bidValue|, |auctionConfigJS|, |trustedScoringSignalsJS|, |browserSignalsJS|»,
and |timeout|.
</div>

Expand Down