-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make API nginx log once per request #3163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I'm missing some steps, are those the full instructions? I remember some slightly different steps to test nginx locally but I can't find them exactly.
Also, I notice now there are two Nginx services under the api profile, proxy
and nginx
, are both serving the same/similar goals? Can't they be combined?
I'm requesting changes for clarification on how to test this and responses. The questions go to @sarayourfriend and @dhruvkb too in case you know, given you have worked more closely with these services.
8fab39d
to
5f0d683
Compare
The "proxy" container is leftover for SSL testing locally. Its presence continues to be confusing to lots of people, and @dhruvkb and I have talked about getting rid of it: I don't know if there's an issue though. @dhruvkb do you remember/can you create an issue with whatever we decided, if you remember that? |
5f0d683
to
7c9a2d0
Compare
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @krysal Excluding weekend1 days, this PR was ready for review 7 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
7c9a2d0
to
0a8ea69
Compare
Fixes
Fixes #3126 by @obulat
Description
While reviewing #3108, I found a way to make Nginx log only once, using the json style described in the
nginx.conf.template
, to the frontend nginx container.This PR adds the same changes to the API nginx container.
Testing Instructions
Rebuild the api and nginx containers (use
just recreate
, or delete theopenverse-nginx
image using a GUI and runjust up
), and access the API through the nginx proxy: http://0.0.0.0:50270/v1/images/?q=catCheck the
nginx
container (image name isopenverse-nginx
) logs: there should only be onejson
formatted log per request, and not two logs per request as described in the issue.Here's the logs I saw after opening the api home page and then searching for "cat" images:
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin